diapolo10 / iplib3 Goto Github PK

Hey,

first of all: very nice package and idea :-)

I was looking at the tests and I notice that you just have unit tests and not integration and/or acceptance tests.

About the unit tests. There is a thing that can be done better and it is parametrisation. For instance, in a test you test multiple test cases using assert. This is not optimal. It would be better to have a script with the test cases and one with the tests, and use pytest parametrisation.

If you want I could do it. I'm interested in understanding the package better, and this is a good opportunity to look deeply into your code and doing something good ;-)

let me know

Is your feature request related to a problem? Please describe.
It would be good to know how much of the codebase is being tested. Bonus points for a nice badge!

Describe the solution you'd like
Adding support for Coveralls in the project and its CI/CD GitHub Actions workflow.

Describe alternatives you've considered
None, though this isn't a high-priority issue.

The current state of the project's documentation isn't great - everything is in the source code and README and lacks details.

At present, the critical parts of the library have decent unit test coverage (not that it shows because Coveralls integration is still missing), but more should be added. Furthermore the library could use some integration testing.

The project is currently lacking a clear goal, and I want to achieve some specific level of usefulness before calling this the first official full release. Ideas, feature requests, bug fixes and defining the final interface will be the key points.