dhowe / chinaeye Goto Github PK

To recreate: disable or uninstall extension, do google search, re-enable extension.

Icon shows that search is blocked, as does text, however not redacted.

https://github.com/dhowe/ChinaEye/blob/master/js/background.js#L290
The icon should be updated whenever the current tab changes, but it doesn't make sense to run through the keyword and page check again to get the blocking status of a specific tab that has already been loaded.

tabId: 
{
tabUrl : url,
blockingStatus: status
}

After a page is redacted b/c of a search, it stays redacted even after a new non-blocked search. Here is a search for 'happiness':

after searching for 'grass mud horse'

are we checking the location of the current tab every time the menu is opened?

It is not consistent that yahoo/bing are allowed/blocked...
Currently if the search keyword matches the triggers, the page won't be checked and the menu displays the server info as OK.
However, this would be very strange if the search engine url fails the server tests, which means that the server result displayed is 'ok' if the keywords is blocked, and 'fail' if the keyword is not blocked.

One way to avoid this is to always check server for the webpage.

in fact, maybe this should just replace what we have now, as most blocks will be related to sites, rather than specific pages

but, if it is a search, then we should disable only for that search.

so we need lists (in local storage) for whitelistedSites, whitelistedPages (?), and whitelistedSearches

I'm not sure how this should work exactly, but there needs to be an option for users (if they so choose) to keep CE enabled, but still view their favorite websites without redaction, even if they are blocked. This is sort of an info-only mode: CE still checks the page, but only changes the icon if blocked (and if the menu is clicked, shows the various server responses).

In this case, on Chrome, ChinaEye shows the page redacted, but GFW shows 'timeout'. Is this a valid response?

If so, perhaps it should get a yellow color, but not redacted? Same I think for anytime ANY of the servers is not green.

https://www.google.com.hk/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=grass+mud+horse

Might be related to when the font is loaded.

For publication in Chrome/Opera stores

• Document list-sources (with link to the list itself)
• Document where our result come from

Basics Functions:

1.Test blocked keywords on Search Engines: Google/Bing/Yahoo (Both text and image search)

• Test that webpage is redacted when the keyword is included in the triggers list (grassmudhorse, CCAV, ** )
• After testing with a blocked keyword, test that webpage returns to normal view when the keyword is changed to something else

2.Test sites that are blocked in China: Facebook,Youtube etc.

• Make sure they are correctly redacted.

Background:
Please check the following content with background.html opened and

• Check that ChinaEye gets Triggers from local when installed

• Check that ChinaEye gets Triggers from local storage when reopened

• Check that Trigger List can be successfully updated (By changing CheckInterval in background.js )

Features:

1. Disable for this site
2. Disable for this search

UI:
Pop up

• Check the overall layout, image and texts

1.Mode Switch

• Check that the current mode is correctly indicated with a black background and white text.

2.Servers Info

• Check that all server tests are failed on blocked sites(facebook, youtube).
• Check that all server tests are passed on search engines.

2.Buttons

• If ChinaEye is active and the page is a search result page that ChinaEye supports (Google/Bing/Yahoo): Both "Disable for this site" and "Disable for this search" buttons are visible
• If ChinaEye is active and the page is blocked by failing visit from servers in China: Only "Disable for this site"button is visible
• If ChinaEye is not active because the site is whitelisted, "Resume for this site" button is visible
• If ChinaEye is not active because the search keyword is whitelisted, "Resume for this search" button is visible

also add link and 'supported by' credit...

Blocked on #65

Result in wrong display of server info and buttons.

This seems to happen consistently on certain pages, such as:
https://hk.yahoo.com/?p=us

1. Better Button CSS
2. Wider Pop up
3. "Disable ChinaEye on this page" / "Resume ChinaEye on this page"
4. Any other content for the release?

For example: https://citizenlab.org/2017/04/we-cant-chat-709-crackdown-discussions-blocked-on-weibo-and-wechat/

@jasonqng's list has not been updated in quite some time

1. load best list from some URL on first install
2. periodically check for updates to list
3. add additional search engines

High priority as web is pretty unusable with the plugin until this is fixed (continually having to press disable for the same web sites)

For example, visit nytimes.com, click 'disable for site', then return 20 minutes later, and content is blocked again

Also, what about the case where a search engine is blocked (eg Google) and one actually wants to whitelist the site, not the search... This doesn't seem to work, though it may just be the problem above

better design needed

Hi there,

Is this meant to be an educational tool to emphasize the importance of privacy and an open web? What browser is this for? It sounds fascinating in any case.

Thanks for your time.

not sure design-wise, but I think we need 2 or 3 versions of the icon:

1. enabled/not-blocking (normal case)
2. enabled/blocking (attention-getting)
3. disabled (gray)

• Search Engine Google/Bing/Yahoo (Text/Image)
• Sites that are blocked in China: Facebook
• Get Triggers from local when installed
• Get Triggers from local storage when reopened
• Update List

Are we disabling for the site or for the search query?

No response to changes within the tab: click a link or type in a search keyword and hit enter

not sure how I ended up in this state (perhaps switching away from the browser, then back and re-opening the menu, but neither of the buttons are active/clickable)

I don't get a mouse-over and nothing appears to happen when I click...

more accurate than GFW

E.g., chrome:// pages. Doesn't work to say 'pending' as the wait would be forever...

Since we know such pages are not blocked, we might want to just show green for servers, but perhaps with some kind of note?

Another option (below) would be to simply hide (in the content-script) the server options for such pages (I think I like this better, as the other could be misleading).

https://www.google.com.hk/search?q=Shiu+Fai+Terrace&oq=Shiu+Fai+Terrace&aqs=chrome..69i57j0l5.181j0j7&sourceid=chrome&ie=UTF-8

To reproduce

0.switch on showLogs in background.js
1.Go to google and type "23", The status should be detected as "Block"
2.Now refresh the page. In the background console, the qRegex doesn't return a match from the same url.
3.Refresh the page again, the qRegex works again.

Should first call:

Cache.clear(key);

And then treat as a normal request (since the cache is cleared, the real server request will then be made)

Yes, I suppose this makes sense.

https://www.google.com.hk/webhp?hl=zh-TW&sa=X&ved=0ahUKEwjW86C3n5fRAhWEkpQKHaDsCZYQPAgD#hl=zh-TW&q=%E5%85%AD%E5%9B%9B
https://www.google.com.hk/?gfe_rd=cr&ei=vdljWOnqO4jM8gevgZDIAQ#q=%E5%85%AD%E5%9B%9B

some questions, some suggested changes... some for discussion

Cache server checks so that we never recheck a server unless t seconds have passed

This will probably require a 'recheck now' button on the menu

so that they remain disabled after browser is restarted...

The current popup has nothing clickable after ChineEye is disabled.

appears to hang indefinitely, until I re-enable the search

If the testing url is https://developer.chrome.com/extensions/tabs#method-get,
Great Firewall of China returns "An error occured - please try again later. If the error continues to occur, please contact the webmaster."

If I try the same page with http instead of https, the page work.
But when I tried other pages with https (Facebook, gmail...), I don't see this error.

Show list of active blocked words
Could be accessible from menu, or from an options page, or both

Not sure if an actual problem:

Uncaught Error: Attempting to use a disconnected port object
    at PortImpl.postMessage (extensions::messaging:60:13)
    at Port.publicClassPrototype.(anonymous function) [as postMessage] (extensions::utils:149:26)
    at responseCallback (extensions::messaging:166:16)
    at Object.success (chrome-extension://bmlfgnkacjnbhefiokiheiohpeiomidk/js/background.js:129:7)
    at i (chrome-extension://bmlfgnkacjnbhefiokiheiohpeiomidk/js/jquery-2.2.3.js:2:27151)
    at Object.fireWith [as resolveWith] (chrome-extension://bmlfgnkacjnbhefiokiheiohpeiomidk/js/jquery-2.2.3.js:2:27914)
    at z (chrome-extension://bmlfgnkacjnbhefiokiheiohpeiomidk/js/jquery-2.2.3.js:4:12120)
    at XMLHttpRequest.<anonymous> (chrome-extension://bmlfgnkacjnbhefiokiheiohpeiomidk/js/jquery-2.2.3.js:4:15680)

1.Test blocked keywords on Search Engines: Google/Bing/Yahoo (Both text and image search)

• Test that webpage is redacted when the keyword is included in the triggers list (grassmudhorse, CCAV, ** )
• After testing with a blocked keyword, test that webpage returns to normal view when the keyword is changed to something else

2.Test sites that are blocked in China: Facebook,Youtube etc.

• Make sure they are correctly redacted.

Background:
Please check the following content with background.html opened and

• Check that ChinaEye gets Triggers from local when installed

• Check that ChinaEye gets Triggers from local storage when reopened

• Check that Trigger List can be successfully updated (By changing CheckInterval in background.js )

Features:

• A redacted page is no more redacted after clicking 'Disable for this site'
• A redacted search page is no more readacted after clicking 'Disable for this search'
• Whitelisted pages remain unblocked after refresh.

UI:
Pop up

• Check the overall layout, image and texts

1.Mode Switch

• Check that the current mode is correctly indicated with a black background and white text.

2.Servers Info

• Check that all server tests are failed on blocked sites(facebook, youtube).

2.Buttons

• If ChinaEye is active and the page is a search result page that ChinaEye supports (Google/Bing/Yahoo): Both "Disable for this site" and "Disable for this search" buttons are visible
• If ChinaEye is active and the page is blocked by failing visit from servers in China: Only "Disable for this site"button is visible
• If ChinaEye is not active because the site is whitelisted, "Resume for this site" button is visible
• If ChinaEye is not active because the search keyword is whitelisted, "Resume for this search" button is visible
• If ChinaEye is not active and the page is not whitelisted, "Disable for this site" button is visible and the button is disabled

chinese and english only for now

In the result below, the search term is blocked, but there is no indication in the menu (only the icon which is hard to understand). If this is a quick fix, then lets add it to v1.0. If not, then you can push it to v1.1 (mark with 'next-tasks' milestone)

To reproduce:
1.Go to page https://www.google.com.hk/search?q=grass+mud+horse&biw=1076&bih=948&source=lnms&sa=X&ved=0ahUKEwjl5rv7w4LSAhVIpJQKHT5UDJEQ_AUIBygA&dpr=1
2.The page should be in redacted mode. Click "Disable on this page" in menu.
3.The page is back to normal. And the button in menu should be "Resume on this page"
4.Go to another tab and come back to the page, the button in menu is disabled. (Should still be an active "Resume on this page" button)