The idea would be to use server nicknames in a -srv or similar argument.

Not sure how practical this is to implement any more, now that the foolz instance is dead and I haven't found any other instances save for @Yuuki2012's…but I did have this idea, and it can always be WONTFIX'd.

e.g. .ani Oreimo -r

Obviously only has a visible effect if -n is also specified.

If someone does .ani botnick the bot should return an Easter egg response, maybe like botnick episode <randint> is currently airing on <#currentchannel or botnickTV>

Currently, anitv.foolz.us is refusing connections. I'm not sure when it started doing so, but if it is gone permanently then it can't be the default server any more.

Would be nice to be able to filter on e.g. -ch Tokyo MX. Maybe only support spaces when the argument is specified using = and quotes?

This looks like it'll be an annoying regex problem at best, and a mild nightmare to code at worst.

I've been avoiding work on #5 and #8 (and anything else related to arg parsing) for ages because it's just so annoying to deal in regex. So I'm making a decision: This module should use a real argument parser.

Since argparse is included in Python's standard library, that's probably the way to go. It looks like splitting the input into a list of strings and passing it to the parser will work (according to docs.python.org), and as long as parsing arbitrary argument lists is possible (since sys.argv is irrelevant to this application), everything else is just a matter of reading the docs.

Probably using -ep [0-9]+ argument.

Best to investigate how the AniTV API returns episode numbers and make sure to use the right data type (int/string) and zero-padding (not sure if the API uses it).

Needs to import from sopel instead of willie to be compatible with the 6.x bot framework release/name change. Ideally should try to import from willie if importing from sopel fails, to maintain backward compatibility for the time being.

.ani -ch BS11 bakayatai

For example. Probably accept alternate abbreviations for channel (ch, chl, chan).

There's no particular reason that the API server address shouldn't be configurable at runtime; it just isn't currently supported because of how the config value is loaded.

Actually, there might be a new Sopel API feature in here… Modules could use a way to register a handler function to be run whenever certain config values change. I'll think on that.

Would be nice to have the ability to configure which server to use, since the default specified in the current code has some issues that other people have fixed in their own instances.

Should retain current default, work even if no settings configured, and support private instances that require API keys.

The changes that caused #7 had to be nerfed because they were too good at finding spaces. But spaces should still be required between arguments.

Broken arg-parsing resulted from the code parsing an argument out of the middle and then also removing the spaces on both sides of it, so subsequent matches would usually fail because of the use of \s+. What's needed is enforcing the spaces (or line start/end) in order to match an argument, but making sure to leave one space when the parsed argument is removed from the input. (This may necessitate trim()'ing the search string before calling the AniTV API.)

Alternatively? Don't remove the args from the input as they're parsed. That could be a way toward better predictability.

I guess the real solution would be to actually parse the arguments (say, by tokenization), but whether implemented from scratch or imported from an existing library, that's a lot of effort and maybe even another dependency that shouldn't really be added.

Requested on IRC by users.

Arg parsing is broken in latest master revision. git bisect points to 00fd5a9 as the culprit.

<Ryuunosuke> ani youjo senki -ch BS11
<Kaede> AttributeError: 'NoneType' object has no attribute 'lower' (file
        "/var/lib/sopel/modules/anitv.py", line 91, in anitv)

Line 91 is where this part of the lookup routine happens:

        if args['chan']:
            if args['chan'].lower() not in result['station'].lower():
                continue

Obviously args['chan'] is not NoneType because the first condition is met. Therefore, it must be result['station'] that is throwing the error. In fact, format_result() handles unknown stations, so the search portion of the code must do so also (it runs before the results are formatted, naturally).

Apparently "I think something messed up when you tried to copy that." is caused by the station name containing an & character. So says @Yuuki2012.

Calling this an enhancement, because it's not actually a bug in the module but a bug in AniTV itself.