Git Product home page Git Product logo

code-style's Introduction

code-style's People

Contributors

beefchimi avatar benlast avatar dfmcphee avatar dnerdy avatar ellekasai avatar haroldtreen avatar jamesbull avatar jansepar avatar jeffkamo avatar jeremywiebe avatar johnboxall avatar jvoll avatar kpeatt avatar lizcross avatar mikeklemarewski avatar ry5n avatar scalvert avatar ssang avatar tedtate avatar vmarta avatar yourpalsonja avatar zacharyhalvorson avatar

Watchers

 avatar  avatar

code-style's Issues

Points of discussion moving forward

The styleguide is lookin' real good, but there are still a number of points we need to discuss as a team. Let's try to come to a consensus on these things so we can get this styleguide completed and pushed out as soon as possible.

  • Perhaps we should expand on "State" classes. What about something that is "in-between" states? Do we do anything in the admin that would resemble: --is-off > --is-animating-in > --is-on > --is-animating-out... Generally, I try to avoid this, and often rely on a animation/transition event listener to toggle classes as a callback - but I'm not sure if we are doing that anywhere in the admin either.
  • I feel like "Layout subcomponents" could use a bit more elaboration. Why is this good / bad?
  • I would argue that Psuedo-classes such as :hover, :active, and :focus (move these out of psuedo-classes and consider them psuedo-styles?) should come after Psuedo-elements (if not at the very end of our ordering). Example: often a psuedo-element will need to respond to the :hover of its parent. Isn't it more organized to wrap all of that up in a single declaration?
  • I think our "Notes" direct comments should indicate that it is a note. So, // note 1 instead of just // 1... reason being, if the line where flex: 0; // 1 someone could read that as "this value was originally 1... I wonder why they changed it?" Should probably discuss comment style further with the team.
  • Naming conventions for mixins or functions.
  • Expand on the Size units?
  • SASS map for colors? Dom is already experimenting with this - could be incredibly useful!
  • How about a map for z-index? What would this look like? Trying to wrangle our stacking context can be a house of mirrors - make it easier to keep track of and shepherd FEDs towards a cleaner implementation.
  • Should we lock font-weight into a variable? ($fontweight--semibold, $fontweight--bold, etc), that way people don't do stupid shit like: font-weight: 200; "cuz I likes it thin".... easily disputable - anyone who writes a style like that probably doesn't care what our variables say anyways :(
  • What are our thoughts on utility classes? Should these be prefixed with something? ex .util-something
  • Is there too much "assumed knowledge" in the way our style guide is written? Is this a concern? Would we rather only hit the main points and be as succinct as possible, or go into more detail as to cause/effect, philosphy, etc?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.