dfellis / h3-node Goto Github PK

Scanned through the docs of both projects, this is what's missing to reach parity:

• h3GetFaces
• h3ToCenterChild
• pointDist
• cellArea
• exactEdgeLength
• getPentagonIndexes

These all seem simple enough functions that it shouldn't be a problem to add them all in one PR. Maybe a bit later today depending on spare time.

why did I have this error: require is not defined at Object.eval?

So before h3-node can reach parity with h3-js, I have to implement the h3SetToMultiPolygon function from it, which has the interesting distinction of being the only H3 function that is only available to h3-js users, since a critical component of it is written in the binding instead of at the C level.

There are roughly three ways that I can tackle this, in order of difficulty:

1. Expose the h3SetToLinkedGeo and destroyLinkedPolyon functions and then mostly-copy-paste the h3-js Javascript implementation.
2. Implement the readMultiPolygon function in C using N-API to construct the Array-of-Arrays-of-Arrays-of-Doubles.
3. Implement the readMultiPolygon function in C in the core H3 library with a new struct type to construct the Array-of-Arrays-of-Arrays-of-Doubles and then port h3-js and h3-node to use this form, instead.

The third option is the most preferable, because that will unlock this functionality for the Python, Go, and Java bindings, as well as, of course, the direct C users and any third-party bindings (though none of the third party bindings have prioritized 100% parity that I can see so far). But I also don't know when I will be able to get time to do it, because the other bindings have all been relatively simple and I could squeeze in a few here or there in my schedule, besides polyfill (but since I wrote that originally for the C, JS, and Python H3s I knew what to do), while this will probably require literal full working days of time in larger contiguous blocks so I can keep the problem in my head.

The first option is basically punting the can down the road, and the second option seems like an evolutionary cul-de-sac since it would be extra effort to do but would also be thrown away like the first option once the third is done.

@isaacbrodsky @nrabinowitz what are your thoughts on this problem?

I am facing issue as mentioned below while installing the h3-node :

C:\users\pranjal gupta\Desktop\app-server\node_modules\h3-node>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild --target=10.16.0 --target_arch=x64 --release ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --target=10.16.0 --target_arch=x64 --release )
gyp ERR! configure error
gyp ERR! stack Error: Command failed: C:\Users\Pranjal Gupta\AppData\Local\Programs\Python\Python38\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack File "", line 1
gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack at ChildProcess.exithandler (child_process.js:294:12)
gyp ERR! stack at ChildProcess.emit (events.js:198:13)
gyp ERR! stack at maybeClose (internal/child_process.js:982:16)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--target=10.16.0" "--target_arch=x64" "--release"
gyp ERR! cwd C:\users\pranjal gupta\Desktop\app-server\node_modules\h3-node
gyp ERR! node -v v10.16.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-gyp exited with 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] prebuild: bash .prebuild.sh
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Pranjal Gupta\AppData\Roaming\npm-cache_logs\2020-04-08T05_42_42_844Z-debug.log
npm WARN [email protected] requires a peer of rbush@^2.0.2 but none is installed. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: bash -c "if node-gyp-build-test; then node-gyp-build; else npm run prebuild && node-gyp-build; fi"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Pranjal Gupta\AppData\Roaming\npm-cache_logs\2020-04-08T05_42_44_597Z-debug.log

npm ERR! code ELIFECYCLE npm ERR! errno 2 npm ERR! [email protected] install: bash -c "if node-gyp-build-test; then node-gyp-build; else npm run prebuild && node-gyp-build; fi"`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\ptipl\AppData\Roaming\npm-cache_logs\2021-03-02T10_19_35_292Z-debug.log`

I am considering using this in one of my projects. Just wanted to ask whether there is a plan to port to H3 4.x? There are some new functions in 4.x that I need.
Thanks for the awesome work.

command not found: cmake is happing while installing.

Now that it's been converted to Github Actions and build artifacts are working, it should be possible to write a publish script that downloads the artifacts, shoves the relevant pieces into the prebuildify directory, and then includes them in the artifact published to NPM.

But I've spent way more than the time I wanted to allot to working on this repo today, so this is a reminder to tackle this another day.