Comments (6)
That is why I just append new voices to the end and have a excel to create the file just in case. But it would be nice if the file supported non-contiguous
from deviation.
I was never overly satisfied with the whole voice handling, but it grew out of limits due to unidirectional communication with dfplayer and ram limitations on some targets. If we use internal id's in the model files, those can't be edited manually anymore, which is also not a good solution.
from deviation.
The current implementation already uses internal ids in model files, they just happen to look like the real mp3 ids. Manual editing shouldn't get any harder after the change.
Although on the topic of causing new issues, I realise now that that naive fix could screw up model files for users who have non-standard edited voice files that unknowingly hit this bug.
That could be fixed by being able to read two types of value, such as HOLD0=200
for old loading behaviour and HOLD0=mp3-200
for new loading behaviour -- then old config can't be broken (I'm not sure what an appropriate prefix would be though; mp3-
or ini-
seem appropriate, but aren't very descriptive)
from deviation.
I went ahead and made a branch with this fixed: https://github.com/somewhatlurker/deviation/tree/model-voiceid-fix
Feel free to play around with it and see if you think it makes sense.
from deviation.
Can you make a PR? It's always easier to have Travis checking things early on.
from deviation.
Sure
from deviation.
Related Issues (20)
- redpine white-screens on Devo7e HOT 10
- Bug in getting started guide
- binding wltoys with v202 protocol HOT 1
- DFUse - Driver
- LOLI protocol not shown up HOT 1
- Bug ? T8SGV2 Plus - Protocol PXX - impossible to bind with PPM IN set to extend HOT 2
- Nightly builds broken HOT 6
- T8SG does not have XK protocol
- CRSF device names longer than 12 characters break the device page HOT 6
- Crash after trying to update configuration HOT 1
- CX10_NRF24L01 for Q222 HOT 12
- Traxxas protocol? HOT 15
- DSMP problem with lemonRX
- SX1280 based targets
- Support ELRS on T8SG V2 Plus HOT 10
- Add support for V119S sub type E119
- LCD screen distorted HOT 2
- (Solution) Hubsan Telemetry - Here is how to read all of it.
- Return button, returns 2 screens
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deviation.