Git Product home page Git Product logo

Comments (13)

l0rd avatar l0rd commented on June 30, 2024

cc @johnmcollier @elsony

from api.

davidfestal avatar davidfestal commented on June 30, 2024

This feature seems to be very valuable in both the devfile and the devworkspace API (which can live under the form of a Kubernetes CR) cases.
And to allow it to be usable in as many use-cases / contexts as possible, I think we should allow abstracting the source of these mappings, so that we do not depend on paths where the file is stored (either on disk or on the network).
Using paths in the case the devfile is stored at a given URI is perfectly fine, as long as it would not be the only way to use this feature.

from api.

benoitf avatar benoitf commented on June 30, 2024

can we change permissions of files/directories or use another entrypoint script as well ?

from api.

l0rd avatar l0rd commented on June 30, 2024

@davidfestal and @l0rd to provide a new alternative that use the initcontainer approach used for the che plugins.

from api.

triceam avatar triceam commented on June 30, 2024

Tangentially related question, but is not in context of the feature discussed above:

If I used a query param to pass a dev file to CRW/che like so:
https://<your-che-host>/f?url=https://pastebin.com/raw/ux6iCGaW

If che didn’t have an access token for a private git repo in the devfile already, what would happen? Would it be prompted to authenticate? Obviously we wouldn’t even get to this mapping/path/initialization.

from api.

l0rd avatar l0rd commented on June 30, 2024

Review and agreed on the alternative syntax specified in the description.

A couple of comments related to this issue and we will need to discuss on separate issues are:

  • Init container that mount projects sources (from git, local, zip) before any other component starts
  • Specify components that run in distinct pods or main pod => won't be possible to share volumes

from api.

l0rd avatar l0rd commented on June 30, 2024

Tangentially related question, but is not in context of the feature discussed above:

If I used a query param to pass a dev file to CRW/che like so:
https://<your-che-host>/f?url=https://pastebin.com/raw/ux6iCGaW

If che didn’t have an access token for a private git repo in the devfile already, what would happen? Would it be prompted to authenticate? Obviously we wouldn’t even get to this mapping/path/initialization.

@triceam as mentioned on slack git access tokens (and user credentials in general) should not be part of the devfile specification because they are not part of a workspace definition but related to a given user. In other words, how users are prompted for username/password/tokens is an implementation choice of the application that processes the devfile (i.e. che or odo).

from api.

l0rd avatar l0rd commented on June 30, 2024

This issue may be affected by #32 that is under review: if we agree that events are better we should probably not support initiContainers anymore.

from api.

metlos avatar metlos commented on June 30, 2024

One might still find use for the init containers if a tool required for the initialization is not present in the target image of the tooling. For example if you wanted to download something using curl, yet the compiler/build tool image you'd like to use lacked curl in its image.

from api.

metacosm avatar metacosm commented on June 30, 2024

What is the status of this issue? initContainer doesn't appear in the schema so has #32 superseded this issue?

from api.

l0rd avatar l0rd commented on June 30, 2024

What is the status of this issue? initContainer doesn't appear in the schema so has #32 superseded this issue?

@metacosm correct, I am keeping this open because initContainer can still be interesting in future releases of the spec but it won't be part of 2.0.

from api.

Jdubrick avatar Jdubrick commented on June 30, 2024

Moving to refinement to revisit and see if this is still needed.

from api.

github-actions avatar github-actions commented on June 30, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.