Git Product home page Git Product logo

Comments (3)

thepetk avatar thepetk commented on August 17, 2024 1

Started looking into this issue. I noticed when trying to run generate_last_mod_file.sh when there are samples present that don't have versions it will error out as the JSON parsing can't find the versions key. For reference about samples that don't have versions I was using the ones from registry-support tests and also noticed there is no revision.

This got me thinking about how we want to go about this, since for some of these yaml fields it isn't necessary we would need to have support for building all different combinations. I know our community registry will all have versions and revision but for others hosting their own registries do we want to accommodate every combination or have it up to their discretion to alter it?

wdyt @michael-valdron @thepetk

With our current format I think is necessary to support all combinations. The registry-support tests should also make sure of this (so we should have sufficient test cases). TBH I don't have a strong opinion if we should make a convention that the last modified field should be used only for versioned stacks/samples, although in that case we should make sure that our documentation makes it clear.

Slightly different scope, but your point makes me think of registry versioning. Meaning, if we had a versioning for the registry repo and a proper release process, for issues like that we could just create a new major version which introduces breaking changes.

from api.

Jdubrick avatar Jdubrick commented on August 17, 2024

Related issue: #1327

from api.

Jdubrick avatar Jdubrick commented on August 17, 2024

Started looking into this issue. I noticed when trying to run generate_last_mod_file.sh when there are samples present that don't have versions it will error out as the JSON parsing can't find the versions key. For reference about samples that don't have versions I was using the ones from registry-support tests and also noticed there is no revision.

This got me thinking about how we want to go about this, since for some of these yaml fields it isn't necessary we would need to have support for building all different combinations. I know our community registry will all have versions and revision but for others hosting their own registries do we want to accommodate every combination or have it up to their discretion to alter it?

wdyt @michael-valdron @thepetk

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.