Comments (3)
Started looking into this issue. I noticed when trying to run
generate_last_mod_file.sh
when there are samples present that don't have versions it will error out as the JSON parsing can't find theversions
key. For reference about samples that don't have versions I was using the ones fromregistry-support tests
and also noticed there is norevision
.This got me thinking about how we want to go about this, since for some of these yaml fields it isn't necessary we would need to have support for building all different combinations. I know our community registry will all have
versions
andrevision
but for others hosting their own registries do we want to accommodate every combination or have it up to their discretion to alter it?wdyt @michael-valdron @thepetk
With our current format I think is necessary to support all combinations. The registry-support
tests should also make sure of this (so we should have sufficient test cases). TBH I don't have a strong opinion if we should make a convention that the last modified field should be used only for versioned stacks/samples, although in that case we should make sure that our documentation makes it clear.
Slightly different scope, but your point makes me think of registry versioning. Meaning, if we had a versioning for the registry repo and a proper release process, for issues like that we could just create a new major version which introduces breaking changes.
from api.
Related issue: #1327
from api.
Started looking into this issue. I noticed when trying to run generate_last_mod_file.sh
when there are samples present that don't have versions it will error out as the JSON parsing can't find the versions
key. For reference about samples that don't have versions I was using the ones from registry-support tests
and also noticed there is no revision
.
This got me thinking about how we want to go about this, since for some of these yaml fields it isn't necessary we would need to have support for building all different combinations. I know our community registry will all have versions
and revision
but for others hosting their own registries do we want to accommodate every combination or have it up to their discretion to alter it?
wdyt @michael-valdron @thepetk
from api.
Related Issues (20)
- Add test devfile registry deployment to index generator testing workflow
- Fix external references in test sample entries
- devfile special envs cannot be defined last in the env list HOT 5
- Devfile Registry nightly run fails for `ollama` stack HOT 3
- for a single minor version, library should support all previous patches with latest schema
- Copy odo-devfile starter projects to devfile-samples org HOT 2
- Publish `0.3.0` release for registry-operator HOT 3
- Spike: Enable Konflux build pipeline
- Implement Multi Arch Support For Devfile Repositories
- [Spike] Investigate documentation updates for pod - container overrides
- Community Registry Showing Default Date for lastModified
- Error logged with Quarkus stacks related to telemetry usage HOT 1
- Error logged with Quarkus stacks related to LogManager
- Update `odo` to `v3.16.1`
- Add DCO to docker plugin repo
- Bump up `github.com/docker/docker` to `v25.0.6` version. HOT 4
- Release `devfile/api` new `v2.3.1` version HOT 1
- [Spike] Investigate root-component based language weights for alizer analyze command
- Update CodeQL GitHub Action to v3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.