devfactorych / taxonomy Goto Github PK

Who wants it? Can we have it?

Lets have a looser coupling of Taxonomy dependencies. From concrete models Devfactory\Taxonomy\Models\Vocabulary and Devfactory\Taxonomy\Models\Term to contract/interfaces/

Why want it? so App can add additional attributes to the models or additional behaviours.

Hi is me again!

at terms index.blade

line: 134 should be
{!! Form::open(array('method' => 'DELETE', 'url' => action('\Devfactory\Taxonomy\Controllers\TermsController@deleteDestroy', $child->id))) !!}

currently child terms delete button is pointing to getEdit method which will fail. Thanks.

FatalErrorException in TaxonomyController.php line 17:
Class 'Devfactory\Taxonomy\Controllers\Controller' not found

Using Laravel 5.1
Taxonomy Branch 3.0

Please assist. thanks

I'd really like to see the ability to easily add additional TermRelation models/tables, similar to how Eloquent Meta does things

I'm not sure how this could possibly be implemented with Term::termRelations(). Any thoughts?

Hey!

Is it possible to use eager loading for terms related to model?

https://laravel.com/docs/5.3/eloquent-relationships#eager-loading

taxonomytrait only allow getting all entities in one term id

Is it possible to search for entities which contains multiple term id?? For both AND and OR operations?
(e.g cars with term id: 1 AND 23)
(e.g cars with term id: 13 OR 82)

Laravel 5.2

after installing "devfactory/taxonomy": "3.0.*" and adding
'Devfactory\Taxonomy\TaxonomyServiceProvider', to providers in app.php

got

[Symfony\Component\Debug\Exception\FatalThrowableError]
Fatal error: Call to undefined method Illuminate\Foundation\Application::bindShared()

because of vendor/devfactory/taxonomy/src/TaxonomyServiceProvider.php:53
$this->app->bindShared('taxonomy', function ($app) {...

change bindShared() to singleton() to fix

Fatal error for laravel 5.2

need to change to use Illuminate\Foundation\Bus\DispatchesJobs;

refer to:

http://stackoverflow.com/questions/34589987/trait-illuminate-foundation-bus-dispatchescommands-not-found-error-while-larav

Currently addTerm() returns null:

  /**
   * Add an existing term to the inheriting model
   *
   * @param $term_id int
   *  The ID of the term or an instance of the Term object
   *
   * @return object
   *  The TermRelation object
   */
  public function addTerm($term_id) {
    $term = ($term_id instanceof Term) ? $term_id : Term::findOrFail($term_id);

    $term_relation = [
      'term_id' => $term->id,
      'vocabulary_id' => $term->vocabulary_id,
    ];

    $this->related()->save(new TermRelation($term_relation));
  }

Will send a PR

Below are the warning displayed:

Warning: Ambiguous class resolution, "CreateVocabulariesTable" was found in both "$baseDir . '/database/migrations/2014_10_29_164909_create_vocabularies_table.php" and "/Users/admin/Development/laravel5-default/vendor/devfactory/taxonomy/src/migrations/2014_10_29_164909_create_vocabularies_table.php", the first will be used.
Warning: Ambiguous class resolution, "CreateTermsTable" was found in both "$baseDir . '/database/migrations/2014_10_29_164925_create_terms_table.php" and "/Users/admin/Development/laravel5-default/vendor/devfactory/taxonomy/src/migrations/2014_10_29_164925_create_terms_table.php", the first will be used.
Warning: Ambiguous class resolution, "CreateTermRelationsTable" was found in both "$baseDir . '/database/migrations/2014_10_29_164940_create_term_relations_table.php" and "/Users/admin/Development/laravel5-default/vendor/devfactory/taxonomy/src/migrations/2014_10_29_164940_create_term_relations_table.php", the first will be used.

Could be due to autoload issues.
Performance/Functionalities of the codes are not affected by this.
Using laravel 5.1 and 3.0 Branch.

Hey, I noticed that this uses Sentry and refers to a Helpers class and DispatchesCommands class (amongst others) that does not exist in Laravel 5.2. Are all these classes required?

https://github.com/xdubois/taxonomy-laravel-bundle and https://bitbucket.org/devfactory/taxonomy-laravel-bundle/overview both appear to be older versions of this package. The README files there really should be updated to point to this new version.

As far as I can tell, this package works in the PHP 7 Release Candidates.

However, the composer.json specifies the PHP requirement as ~5.4, meaning that it cannot be installed on a machine running PHP 7.

The composer.json should probably be updated to allow newer versions.

Hej! I'm a Laravel n00b so apologies if this is a stupid question.

It seems there are some Routes defined in the package, but they're not listen when I run php artisan route:list. Are they intended for public consumption and if so, how does one go about using them?!

Thanks!