kontry_uikit's People
kontry_uikit's Issues
Put Views configuration in a separate file with the new YourViewController+View.swift
Views configuration defined in ViewController are making it very large, try to put these configurations in an extension for this ViewController and in a separate file.
ex:
CountryListViewController.swift
CountryListViewController+Views.swift
The use of switch statement for error mapping is breaking SOLID principles
Please use polymorphism to get rid of switch statement when mapping errors in combine stream.
DTO classes should own properties of type relate to UIKit or MapKit, etc..
Please refactor CountryDetailsDto so it mapRegion property is not of type MKCoordinateRegion, and let ViewController handles creating a map object from longitude and latitude properties of CountryDetailsDto
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.