deshack / pinit Goto Github PK

Place Pinterest Buttons, Pins, Boards and Profiles everywhere in you WordPress using simple shortcodes and a fully customizable widget.

It should be

Place Pinterest Buttons, Pins, Boards and Profiles everywhere in your WordPress using simple shortcodes and a fully customizable widget.

Environment

Demo site, Contribute page

Details

Now that GlotPress is available, we should point translators to that instead of the language files bundled with the plugin.

See Build 1.1

$ phpenv global 5.2 2>/dev/null
5.2 is not pre-installed; installing
0.21sbzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
0.00s
0.01s$ phpenv global 5.2
rbenv: version `5.2' not installed

Languages to update:

• en_EN
• es_ES
• it_IT
• pt_PT

Is it good for you if I code this two buttons into shortcode?

Would be a good idea maybe to make the follow button as a widget as well?

Improve readme.txt adding screenshots, improving the description, etc.

• Fix Responsive layouts
• "Advanced" Tab
• "WooCommerce" Tab
• Sidebar link for donate
• Social icons original source in white color
• Sidebar Link to @deshack (TODO)
• SDK Freemius (This could be exploded in a new task and treated later)

I think we can start improving the settings page integrating a "Advanced" tab where put a disabling option for widgets (if you don't use it don't load it at all!) and another one for shortcodes (same story).

Actually this is the admin settings page:

See Enea's comment: https://plus.google.com/u/0/+MattiaMigliorini/posts/Yf1uXD7swAZ

At least in the demo website, we need some info on how to contribute with things like translations.

See #5

Strict Standards: Declaration of WP_Plugins_List_Table::bulk_actions() should be compatible with WP_List_Table::bulk_actions($which = '') in /home/deshack/test/wp-admin/includes/class-wp-plugins-list-table.php on line 0

readme.txt is required by WordPress, but not rendered by GitHub. In order to improve the plugin presentation on GitHub too, we should create a README.md.

It seems like Pinterest made some improvements to the widgets recently, and introduced a new button with counter.

It's really easy to introduce, but maybe we should think about how and where to use it. We could, for example, expose a shortcode for the user to consume, but also something that hooks automatically into the page, maybe below posts, to share the featured image with the post's URL.

@EugenioPetulla this is up to you.

PHP Notice: Undefined index: title in /home/deshack/test/wp-content/plugins/pinit/pinit.php on line 154
PHP Notice: Undefined index: purl in /home/deshack/test/wp-content/plugins/pinit/pinit.php on line 155
PHP Notice: Undefined index: imgWidth in **/home/deshack/test/wp-content/plugins/pinit/pinit.php* on line 156
PHP Notice: Undefined index: boxHeight in /home/deshack/test/wp-content/plugins/pinit/pinit.php on line 157
PHP Notice: Undefined index: boxWidth in /home/deshack/test/wp-content/plugins/pinit/pinit.php on line 158
PHP Notice: Undefined index: select in /home/deshack/test/wp-content/plugins/pinit/pinit.php on line 159

Starting from this shortcode we can create a button for tinyMCE wysiwyg interface.

Do we need a feature like that?

This is a starting discussion point so... let's go! :)

WordPress 4.5 (Beta 1 to be precise) introduces wp_add_inline_script() for including inline JavaScript just like wp_add_inline_style() works for CSS. See the release notes.

wp_add_inline_script() takes dependencies into account (not really useful in our case though) and also adds the ability to filter the code, so that something like what suggested to capabomba would be accomplished by filtering the inline script and not removing the action and adding a new one.

• Single Post (new using method or function to check both parameters)
• Single Pages (new using method or function to check both parameters)
• Front Page
• Tags Archive
• Categories Archive
• Author Archive
• Single Product (WooCommerce)
• Products Archives (WooCommerce)
• Shop Page (WooCommerce)

Add an option for pinit button into archives, frontpage, blogpage, category pages and tag pages.

Maybe the WooCommerce option for products pages could be enabled only if woo is active.

I tested it on WordPress 4.6 and it works like a charm.

s/activate/activated:

This feature will be activate on EVERY image of your website.

s/post/posts and s/could/can:

Activate Pinit buttons in sigle post only (This could be combined with pages)

s/could/can:

Activate Pinit buttons in sigle pages only (This could be combined with posts)

Also, I would remove the only from the last two. only implies that you cannot have both settings active at the same time, but what's written between brackets says the opposite. It's kind of confusing to me.

Steps to reproduce

Go to the Pinit settings page (/wp-admin/admin.php?page=pinit), check the Insert Pinit Button on hover, and change the Button Color setting to either Grey or White. Leave the Round Button setting unchecked.
Go to the frontend, reload the page, and hover over an image.

Expected behaviour

The Pinit button that appears on hover is either gray or white, according to the selection.

What happens instead

The button is still red.

Considerations

Looking at the Pinterest widget builder there is no evidence of this option. Maybe they removed it recently. We should remove it from our plugin too.

Add a check for most popular slider plugins and disable the pin button function.

This could be achieved easily but we have to find a list of the most popular slider and/or carousel plugins.

Anyone want help? @deshack :P

This will cause a big usability bug.

To reproduce the issue drag more than one widget in the same widget area and select the first one as Pin. You will be not able to set size value of the second one because your js is hiding the input boxes.

New pinterest widgets allows us to choose the size (small, medium or large) for pinned image according to their builder: https://developers.pinterest.com/tools/widget-builder/?type=pin&size=large

As a rule of thumbs, Pinit is the plugin name, whereas Pin it is the name of the Pinterest Pin it button.

In the readme we found something like this:

<p>Pinit Button for Japanese Language</p>

Here Pin it should be used instead of Pinit.

I'll take care of looking for all the occurrences of both words and ensure they're consistent throughout the whole project.

Change name to vars of Profile and Board shortcodes in order to reflects the guidelines of WordPress shortcode.

I ran a lot of unit test and sometimes the atts of this two shortcodes do not render as well beacause of this issue.

Now => imgWidth, boxWidth and boxHeight
Future => imgwidth, boxwidth, and boxheight

I love CamelCase, it's my favourite notation but WP it's not confident with so we have to remove it because can cause a lot of troubles. :)

Stefano Agnelli on Wordpress Italy+ was in search of a way of automatically post new posts to Pinterest.

Apparently this is possible, so why not?

@EugenioPetulla may we discuss about that?

I'll try to ask for this!