depsimon / laravel-wallet Goto Github PK

Hi,

This is amazing but it has no documentation for getting transaction detail, or make transaction status pending until successful payment done using payment gateway and then make it success

currently you are not returning transaction detail after creating transaction history in HasWallet.php

$this->wallet->transactions()
            ->create([
                'amount' => $amount,
                'hash' => uniqid('lwch_'),
                'type' => $type,
                'accepted' => $accepted,
                'meta' => $meta
            ]);

instead just add return

return $this->wallet->transactions()
            ->create([
                'amount' => $amount,
                'hash' => uniqid('lwch_'),
                'type' => $type,
                'accepted' => $accepted,
                'meta' => $meta
            ]);

so that we can get detail by,

        $transaction = $user->deposit(100, 'deposit', ['description' => 'Money Deposited to wallet.', 'status' => 'pending'], false);

Can you explain 'meta' column in wallet_transaction table?
thank you!

Should $user->transactions() default to only include transactions that are accepted?

Similar to how Eloquent filters out soft deleted models, but you can use the withTrashed() to include ones that are deleted.

Maybe $user->transactions()->withRejected()->get() if you wanted every transaction or something?

Hello,
Many many thanks for the amazing laravel package.
I am working with the project which is based on a reward system. A reward can be in points, BTC or USD so need your advice that which type of changes does this package require for the same.

Thanks!

Issue:

When using the actualBalance() method in HasWallet, the amount doesn't match balance field on the wallets table as it includes transactions that weren't accepted

Should there be a where('accepted', 1) added to the query builder?

Is there is any chance to get this done sooner

Hi,

Can I know if I use the deposit or withdraw function is that possible race condition happen ?
let say a malicious user try to invoke withdraw function simultaneously, the wallet have balance of 10 and withdrawn 10 simultaneously , can both withdraw success ?

Besides that nice work man!

I want to confirm if this package is still being maintained and if support can be added to php 8.x

hello, when i try to create migration it throws error

In Connection.php line 664:

  SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error i
  n your SQL syntax; check the manual that corresponds to your MySQL server v
  ersion for the right syntax to use near 'json null, `created_at` timestamp
  null, `updated_at` timestamp null) default cha' at line 1 (SQL: create tabl
  e `wallet_transactions` (`id` int unsigned not null auto_increment primary
  key, `wallet_id` int unsigned not null, `amount` int not null, `hash` varch
  ar(60) not null, `type` varchar(30) not null, `accepted` tinyint(1) not nul
  l, `meta` json null, `created_at` timestamp null, `updated_at` timestamp nu
  ll) default character set utf8mb4 collate 'utf8mb4_unicode_ci')


In Connection.php line 452:

  SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error i
  n your SQL syntax; check the manual that corresponds to your MySQL server v
  ersion for the right syntax to use near 'json null, `created_at` timestamp
  null, `updated_at` timestamp null) default cha' at line 1

Hi,

Just playing out with the package, if you try to create transaction on fresh user, it will throw an exception.