In Solarized Light, when viewing .diff/.patch files, the background color of lines starting with + and - is the same as the background color used for selected text. This means that when you select lines in a diff, the selection is effectively invisible.

Using the dark theme, function names in C code look like comments. From the files, it looks like it is because entity.name.function.c is set to base01 instead of base1 (it is the same as in the light theme, instead of the "opposite").

I'm going through and noting some mismatches in the test file(s). I'll start making pull requests for them as I have time, but this way others can help out as well:

• double quotes
• single quotes
• semicolons
• scope resolution operator (double colon)
• new keyword
• echo keyword
• class method calls
• class names
• HTML tag names (should be bold)
• parentheses in PHP embedded in HTML
• < and > in HTML
• HTML attributes
• array constructs
• commas
• 2nd opening parenthesis on lines 18 & 19 (don't know what they'd be called)

I'm not yet any good at writing Textmate selectors, but I'll fill in the color values as I can.

Thanks for the port.

Support for haskell is non-existant, if you know a little haskell and could add the basic rules, that would be great help.

Hi,

I find that when highlighting code, the selection is so faint on the dark theme, it is hardly recognizable? Anyone else have this issue? In the config file, is there a list of line to tweak that highlight on selected text?

Thanks!

It looks like there's something gone awry with the base text color used in this theme under TextMate 2.

Until yesterday, the Solarized theme available as a TextMate 2 bundle was independent of this one. (It didn't support Markdown highlighting, at least.) Yesterday, this changed, but now the base text color renders in some kind of greenish yellow, no matter what the language bundle used. (Try a plain text file to see what I mean.)

Coincidentally, this is the same issue that I found when I tried to convert my copy of this theme into a TextMate 2 version.

It seems as though maybe MacroMates pulled this repo into their theme?

Having a property start with function (for example app.functions) causes bad highlighting for the rest of the code.

Here is an example of the issue I have:

Hey,

I'm looking for a couple of people to help get this theme back into shape. There's still a bunch of work to be done on fixing languages I don't use plus some annoying bugs still lingering around.

Anyone fancy helping out?

I just pulled down dark & light, using RAW and saving locally (not cloned). In Markdown mode I'm not getting any Markdown coloring.

Solarized Dark and Light themes orginally does not color aritchmetical operators e.g. (=, +, -, ++, +=, &&, ||) for any language e.g.

python

java

Sublime Text 3 port follows these setting in some languages e.g. C++, Haskell but for other languages like Python or Ruby it colors these operators same as keywords. This is deviation from orginal theme and additionally it introduces noise.

I have prepared lines that has to be added to make Sublime scheme compatible with orginal one.

Add following lines to dark scheme:

<dict>
    <key>name</key>
    <string>Arithmetical, Assignment, Comparision Operators</string>
    <key>scope</key>
    <string>keyword.operator.comparison, keyword.operator.assignment, keyword.operator.arithmetic</string>
    <key>settings</key>
    <dict>
        <key>fontStyle</key>
        <string></string>
        <key>foreground</key>
        <string>#839496</string>
    </dict>
</dict>

Add following lines to light scheme:

<dict>
    <key>name</key>
    <string>Arithmetical, Assignment, Comparision Operators</string>
    <key>scope</key>
    <string>keyword.operator.comparison, keyword.operator.assignment, keyword.operator.arithmetic</string>
    <key>settings</key>
    <dict>
        <key>fontStyle</key>
        <string></string>
        <key>foreground</key>
        <string>#657B83</string>
    </dict>
</dict>

As it stands, the styles do a poor job of rendering any section of text marked as Invalid.

For instance, in my Git Commit Message context, the first line of the message is marked as Invalid if it's over 51 characters (weird number, I know). In most TextMate themes, as soon as the line exceeds 51 characters the entire line is highlighted in red.

In the Solarized theme, there is a style defined for the Invalid scope, but it's either identical to or indistinguishable from regular body text. I'm proposing that it be changed to use one of the reds as a background with white text as the foreground in order to signal to the user that a section of text is malformed in an important, un-ignorable way.

If I have spotted them correctly on the screenshots:

• Light should be using base2 for invisibles and base00 for invisibles on the highlighted line.
• Dark should be using base02 for invisibles and base0 for invisibles on the highlighted line.

Currently the TextMate port uses base1 in both versions, masking the colour by setting the opacity to 50%.

This might be due to a TextMate theme limitation, I’m not into theming enough to say anything about that. If it is I ask you update the README to mention this differentia. Especially because the 50% modifier might result in a colour that is not part of the canonical palette.

This may just be some misunderstanding of the colour systems being used, but I notice that the background colour used in this theme: #042029 does not match any of the hex colour codes for base03 on the main Solarized page: http://ethanschoonover.com/solarized#the-values. Is this intentional or have the colour codes for Solarized changed since this theme was put together?

I put together a CSS test file (https://github.com/braver/solarized/blob/master/utils/tests/css.css), I'd love to have some feedback and perhaps additions to that before I ask to pull. It highlights a number of issues with the theme for CSS.

Some of the CSS3 stuff looks awful, especially the media queries. I have no clue as to why the closing curly braces should be red, and the parentheses seem inconsistent (I've seen blue, red and grey). It also kinda feels like it doesn't recognise the child selectors.

User Case

1. Actions > Install Extras...
2. Select Themes > Install from File...

Once a file has been chosen it returns to the select themes option but doesn't show the new theme. A restart is needed for the theme to be loaded.

The latest build of TM2 has support for the gutter, if possible we should try and theme if accordingly textmate/textmate#233

The element Ruby: Special Method appears two times in each Solarized variant.

The duplicate elements have identical scopes and distinct foregrounds.

In the dark theme, the selected text colour is hardly recognizable. There seems to be some pull request for this in issue #15, but the issue is still present in the repository.

Strangely, in older version, the textmate theme that can be downloaded from the official solarized site don't have this problem.

Currently you are setting source.css.embedded.html to italics. This is wrong. Only the tag name (style) should use italics. The way it is set-up now attributes (likes type) and the tag itself (< and >) use italics as well.

• source.css.embedded.html should use the regular font.
• source.css.embedded.html entity.name.tag.style.html should use the italic font.

When using this version of Solarized in ST2 it seems like I'm not getting the full gamut of colors in my html.

• What I see: http://cl.ly/0J1L1t372R2C1D3E2L0R
• What The Solarized homepage says I should see: http://ethanschoonover.com/solarized/img/screen-html-dark.png

I suppose it's mostly the orange highlights I'm missing, but I was wondering if this is due to using it in Sublime text, or an issue with the theme.

Solarized uses a dark blue color, what you get from this theme is turquoise.

Current background:

Solarized background:

It would be wonderful if the light and dark themes included Markdown syntax highlighting. I believe the necessary scope selectors in TextMate are as follows:

• markup.italic
• markup.bold
• markup.underline
• markup.quote
• markup.heading, markup.heading entity
• markup.list
• markup.raw
• markup comment
• meta.separator

I'm not 100% sure on these. I'm fairly new to using TextMate, and I've parsed this from looking at other themes such as IR_Black and Succulent.

Cheers.

I'm not a big Markdown user, but I'm aware that a lot of you would like to see Markdown support.

Does anyone have any good markdown samples they could provide which would help providing highlighting in all the right contexts?

( Note: Dunno if this is a TM2 issue or a Solarized issue. Apologies if this is misfiled. )

I’m pretty sure lineHighlight is supposed to offer an alternate bg color for the caret’s current line.

If this is the case, then it seems it’s not working for me at all. The current line is indistinguishable from others. I’ve even tried putting in some ludicrous colors for lineHighlight without luck. :(

Is this fixable? Any advice?

'Selection' color must be the same as 'lineHighlight' - #EEE8D5, but it is #073642
https://github.com/deplorableword/textmate-solarized/blob/master/Solarized%20(light).tmTheme#L23

can not be use with textmate 2

I'm using the newest solarized dark theme in Sublime Text.

When Sublime window is in focus, the highlighted text has a nice bright color contrasting with the dark background. However, when out of focus, the highlight color becomes a gray color which is very close to the text color, rendering the text unreadable.

Is there a good solution for this?

Steps:

1. Open a Find dialog in a project (Cmd-Shift-F).
2. Search for something common. "the" for example.
3. Click one of the results found by the dialog.

It opens up the page that contains the result and highlights the text, but it doesn't seem to scroll to put the highlighted text into the visible window. Sometimes clicking the result a second time will center the text in the visible window (other times it seems to misfire). But that seems like it ought to happen on the first click. At least, whatever it's doing now feels counterintuitive.

The current perl formatting is non-existant, any rules from someone who knows Perl would be most helpful :)

I was just looking at the canonical Vim screenshots of Solarized and noticed there are 2 different versions of Javascript syntax highlighting in the original.

Javascript within HTML (screenshot dark, light) is based on orange while standalone Javascript (screenshot dark, light) is based on a base colour.

Should this TextMate port support both variants or are we going to choose one? My guess is @altercation did not specify colours for those elements that switch colour and has a base grey as default colour for standalone but orange as default colour for embedded scripts. That would mess things up.

I know TextMate bundles make use of variables, but I’m not certain if it’s possible to use variables in a theme-only bundle.

If it is possible, though, please consider defining all the colors as variables.

References

Image Palette

Color Defs

SOLARIZED HEX     16/8 TERMCOL  XTERM/HEX   L*A*B      RGB         HSB
--------- ------- ---- -------  ----------- ---------- ----------- -----------
base03    #002b36  8/4 brblack  234 #1c1c1c 15 -12 -12   0  43  54 193 100  21
base02    #073642  0/4 black    235 #262626 20 -12 -12   7  54  66 192  90  26
base01    #586e75 10/7 brgreen  240 #585858 45 -07 -07  88 110 117 194  25  46
base00    #657b83 11/7 bryellow 241 #626262 50 -07 -07 101 123 131 195  23  51
base0     #839496 12/6 brblue   244 #808080 60 -06 -03 131 148 150 186  13  59
base1     #93a1a1 14/4 brcyan   245 #8a8a8a 65 -05 -02 147 161 161 180   9  63
base2     #eee8d5  7/7 white    254 #e4e4e4 92 -00  10 238 232 213  44  11  93
base3     #fdf6e3 15/7 brwhite  230 #ffffd7 97  00  10 253 246 227  44  10  99
yellow    #b58900  3/3 yellow   136 #af8700 60  10  65 181 137   0  45 100  71
orange    #cb4b16  9/3 brred    166 #d75f00 50  50  55 203  75  22  18  89  80
red       #dc322f  1/1 red      160 #d70000 50  65  45 220  50  47   1  79  86
magenta   #d33682  5/5 magenta  125 #af005f 50  65 -05 211  54 130 331  74  83
violet    #6c71c4 13/5 brmagenta 61 #5f5faf 50  15 -45 108 113 196 237  45  77
blue      #268bd2  4/4 blue      33 #0087ff 55 -10 -45  38 139 210 205  82  82
cyan      #2aa198  6/6 cyan      37 #00afaf 60 -35 -05  42 161 152 175  74  63
green     #859900  2/2 green     64 #5f8700 60 -20  65 133 153   0  68 100  60

Ideal Usage

Currently, the global settings for Solarized (Light) look like this:

settings = {
    foreground = '#586E75';
    background = '#FDF6E3';
    caret = '#000000';
    invisibles = '#EAE3C9';
    selection = '#EEE8D5';
    lineHighlight = '#EEE8D5';
};

It would be great if it were more like this:

settings = {
    foreground = '$base01';
    background = '$base3';
    caret = '#000000';
    invisibles = '#EAE3C9';   // this color isn’t listed in Solarized
    selection = '$base2';
    lineHighlight = '$base2';
};