deltares-research / netcdf_to_gltf_converter Goto Github PK

Related to #25

Add GitHub actions for:

• Automated tests
• Automated formatting of code

Related to #25

It should be possible to transform our z-coordinates to another coordinate system, e.g. WGS84.
Why: The curvature of the earth is not taken into account in many of our source (netCDF) data while Cesium does project on a curved surface. Converting the z-values to an ellipsoidal height should take care of that.

TODO

• Add an extra configuration to the config file: crs_transformation (when making it generic for all the coordinates incl, x,y,z or z_crs_transformation for only transforming the z-coordinates.
• Document the new configuration in the user manual

Note that #83 should first be implemented before this.

Related to #25

We can use meshkernel or maybe also xugrid for this.

Currently we shift the x- and y-coordinates by substracting the minimal x and y value, respectively, such that the smallest coordinate will be shifted to 0,0.
This setting is enabled when "shift_coordinates": true in the configuration file.

We want to make it possible that the user can specify the x and y shift in the configuration file (assuming the target coordinate system if specified).

• No validation is current needed for the input.
• Add settings to the configuration file
  • Make "shift_coordinates" setting optional
  • Optional values: min or settings per x/y:

	"shift_coordinates": "min",

or

	"shift_coordinates": 
	{
		"shift_x": 12000,
		"shift_y": 99,
	},	

• Update the documentation in the README.md

High water depth: darker blue
Lower water depth: lighter blue
Water depth 0: transparent

Since most/all glTF viewers do not support color animation, would it be possible to create a mesh for each time step, and apply morphtargets to hide/unhide them?

Related to #25

Such that a mesh will not be generated for vertices that have a value below 0.01m for example.

The workflow consists of the following:

1. The user picks a WGS84 x,y, z coordinate (on Google maps for example). The point is the zone of interest.
2. Internally these points are converted to the coordinate system of the original model (e.g. Amersfoort / RD New + NAP height)
3. All the xyz-coordinates are shifted (subtracted) with the x-value, y-value and z-value of the point from step 2.

Config example:

	"shift_coordinates": {			--- optional
		"crs_transformation": {      --- optional
			"source_epsg": 7415,
			"target_epsg": 4979
		},
		"shift_x": 51.3,		
		"shift_y": 3.4,
		"shift_z": 40
	},

• Get variable by name, not by standard name
• Use "use_threshold", don't use threshold object.

For example, we make one mesh with light blue between 0 and 0.1m, a darker mesh between 0.1m and 0.3 and another darker mesh for every value >0.3m

User can enable or disable
User can set the height
User can set the color

Start using a configuration file.

The provided NetCDF should be able to be read by the converter.
For now it should be able to read:

• The 2D mesh: vertices, faces, edges
• Variables such as the water depth: x, y, z

When integrating in an environment, this would make it easy to cut out some of the submeshes if they lay outside the area to visualize. This would increase rendering performance.

The plane will have the same vertex positions as the data mesh. Rendering one big plan across the scene will lead to weird visual glitches.

• Add optional settings for the configuration file, e.g.:

	"crs_transformation" : 
	{
		"source_crs": 28992,
		"target_crs": 4326
	},

• Document the settings in the README.md
• Make sure that the configuration is used and the coordinates are transformed to the new crs

• Model output should be converted to WGS84
• Coordinates need to be shifted to a specific point of the Westernscheld e.g. x=3.984524, y=51.410069 (these coordinates should become the reference point (0,0).

Needs issues #71 and #75

3d-tiles/README.md at main · CesiumGS/3d-tiles · GitHub

• Add optional settings for the configuration file, e.g.:

	"crs_transformation" : 
	{
		"source_epsg": 28992,
		"target_epsg": 4326
	},

• Document the settings in the README.md
• Make sure that the configuration is used and the coordinates are transformed to the new crs

Related to #25