deltadao / gaia-x-testnet-statistics-api Goto Github PK

Motivation / Problem

Currently, most functions do not have a return type. So we do not benefit from the full advantages of Typescript type checking.

Solution

Add return types to all functions.

Motivation / Problem

As a Gaia-X testnet node provider,
I must know if all nodes are syncing as expected
because malicious nodes might affect the network resulting in either unresponsiveness or log spamming.

Solution

• Check if blocks are produced every ~5 seconds
• create a notification for Slack when the network deviates from expected blocktimes

Summary

Because of slow data fetching it's possible that the same cron job runs multiple times in parallel.

Current Behavior

Same cron job runs in parallel

Expected Behavior

Same cron jobs can not start if already running

Motivation / Problem

We want to keep the statistics updated.

Solution

We want to use node-cron to start import scripts

Motivation / Problem

TypeScript team recommends not I-prefixing interfaces. See a detailed answer here: https://stackoverflow.com/a/41967120

Solution

Refactor our interfaces to not use the "I"-prefix anymore. This also means we need to rename some other components, like models & implementations.

I suggest using names like

interface Cat { }

class Lion implements Cat { }

// Database models
class CatModel {}

Alternatives

We can simply keep the "I" prefix for interfaces and not care about the drawbacks.

Summary

Transactions are not fetched correctly. Logs print the following error:
Cannot destructure property 'hash' of 'transaction' as it is null.

Current Behavior

When the DB is empty and the data fetching is started the error below is thrown.

Cannot read properties of undefined (reading 'blockNumber') at getLatestEventBlockNumberFromDb 

Expected Behavior

When the DB is empty the program will start to fetch blocks from 0.

Motivation / Problem

Block fetching takes a long time. We want investigate on possibilities to improve fetching speed.

Solution

Check the use of Promise.all in the block fetching function => running several queries in parallel instead of sequentially