Git Product home page Git Product logo

rod-licensing's Introduction

Build Status Quality Gate Status Maintainability Rating Reliability Rating Security Rating Lines of Code Coverage Bugs Code Smells Technical Debt Vulnerabilities Lerna JavaScript Style Guide Jest GitHub issues Code size Repo size Licence

Rod Licensing Digital Services

Mono-repo for the rod licensing digital services.

Prerequisites

  • Node v14.13+
  • Docker v18.06.0+

Cloning

Cloning via SSH from behind a firewall which blocks port 22:

git clone ssh://[email protected]:443/DEFRA/rod-licensing

Using Lerna

This project uses Lerna to simplify the management and versioning of multiple packages which comprise the rod licensing digital service.

Running npm install in the root project will automatically run the lerna bootstrap command. The result is that any local packages which depend on one another will be linked locally (using symbolic links).

Running npm run lerna:clean will remove all local node_modules.

Running lernaupdate will enter an interactive wizard to allow updates of each packages dependencies.

Running lernaupdate --non-interactive --dependency "aws-sdk@latest" will update the aws-sdk dependency in all packages which use it.

Package structure

packages/

docker/

  • infrastructure.yml

    Local development infrastructure docker compose file

  • services.build.yml

    This contains the necessary definitions to allow docker images to be built both in development and production mode

  • services.dev.yml

    This contains the necessary definitions to allow the services to be run in development mode.

  • services.yml

    This contains the necessary definitions to allow the services to be run in production mode.

Contributing to this project

Please read our contribution guidelines

License

THIS INFORMATION IS LICENSED UNDER THE CONDITIONS OF THE OPEN GOVERNMENT LICENCE found at:

http://www.nationalarchives.gov.uk/doc/open-government-licence/version/3

The following attribution statement MUST be cited in your products and applications when using this information.

Contains public sector information licensed under the Open Government license v3

About the license

The Open Government Licence (OGL) was developed by the Controller of Her Majesty's Stationery Office (HMSO) to enable information providers in the public sector to license the use and re-use of their information under a common open licence.

It is designed to encourage use and re-use of information freely and flexibly, with only a few conditions.

rod-licensing's People

Contributors

dependabot-preview[bot] avatar dependabot[bot] avatar dgajewska avatar graham-willis-druid avatar io-timeout avatar irisfaraway avatar jaucourt avatar lailien3 avatar mickstein avatar nabeelamir-defra avatar philhunt-defra avatar scottdormand96 avatar traviscibot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

rod-licensing's Issues

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.40.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.39.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.38.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Documentation

(1) It would be useful I think to have some step by step documentation on how to run the sales API locally. The dynamics library requires a set environment variables yet these variables are actually required by the client of the library - the sales API.
I think a guide for local running in the top level README would be useful as much of the information is distributed.
(2) The OAUTH_HOST requires a trailing backslash https://login.microsoftonline.com/ for the system to start. This is probably a gotcha that is best removed.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/connectors-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating govuk-frontend in /packages/gafl-webapp-service/package-lock.json:
No matching version found for @defra-fish/[email protected].

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating @hapi/joi in /packages/sales-api-service/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/dynamics-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.37.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating uuid in /packages/gafl-webapp-service/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/business-rules-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating uuid in /packages/gafl-webapp-service/package-lock.json:
No matching version found for @defra-fish/[email protected].

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.35.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Shouldn't be using Midnight and Midday in the web journey

Shouldn't be using Midnight and Midday - the improvements made to the current service to use 12:01 etc were well received in user feedback.
We should use this as a starting point until there is evidence for something better.

PR Conversation History
@sgardnerdell-ea
sgardnerdell-ea 16 hours ago Member
Shouldn't be using Midnight and Midday - I appreciate this is a little up in the air at the moment but the improvements made to the current service to use 12:01 etc were well received in user feedback.
We should use this as a starting point until there is evidence for something better.

@graham-willis-druid
graham-willis-druid 1 hour ago โ€ข
Author Member
I am uncomfortable doing this. Regardless of any 'user research' or previously established rule this is incorrect a priori. On a previous page you have given the user the option to select midday as a licence start time and this is what should be played back. IMHO it looks ridiculous to then translate that into 12:01pm. If it is 12:01 pm then the radio button should be labeled that way. Let us tell the user accurately when his licence starts and ends please. Can we discuss.

@sgardnerdell-ea
sgardnerdell-ea 6 minutes ago Member
I agree with you that it should be consistent throughout the journey and any communications but I don't think we can revert back to something that was less favourable with our users especially when we have metrics to support the change to use 12:01 etc.

Originally posted by @sgardnerdell-ea in #136

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/pocl-job/package-lock.json:
No matching version found for @defra-fish/connectors-lib@^0.0.1-beta.33.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating pdfmake in /packages/gafl-webapp-service/package-lock.json:
No matching version found for @defra-fish/[email protected].

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating aws-sdk in /packages/sales-api-service/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/dynamics-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating govuk-frontend in /packages/gafl-webapp-service/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/business-rules-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating ssh2-sftp-client in /packages/fulfilment-job/package-lock.json:
No matching version found for @defra-fish/[email protected].

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Dependabot can't resolve your JavaScript dependency files

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating pdfmake in /packages/gafl-webapp-service/package-lock.json:
404 Not Found - GET https://registry.npmjs.org/@defra-fish/business-rules-lib - Not found

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.