defaultxr / bdef Goto Github PK

The function frame-to-op-1-format is completely broken, and seems to a mis-interpretation o fthe code in https://github.com/padenot/libop1/blob/master/src/op1_drum_impl.cpp. The function frame-to-op-1-format.new is close to what the C code does. To do precisely what the C code does it needs to do:

 (* (floor +op-1-drumkit-end+ +op-1-bytes-in-12-sec+)
      frame +size-of-uint16-t+)

[assuming that frame is an integer]

op-1-format-to-frame also broken. The function op-1-format-to-frame.new multiply by +size-of-uint16-t+ instead of dividing by it. To match frame-to-op-1-format, op-1-format-to-frame needs to do:

(round
   (/  op-1
       (* (floor +op-1-drumkit-end+ +op-1-bytes-in-12-sec+)
          +size-of-uint16-t+)))

The test op-1 will not work as is even after the fix, because op-1 value of 40 is rounded to 0. Switching the calls, so 40 is the frame number, make it work with the fixed functions.

Building with SBCL 2.1.10.195-bca540cd6 / ASDF 3.3.5 for quicklisp dist creation.

Trying to build commit id 9a20de6

bdef/cl-patterns fails to build with the following error:

; caught WARNING:
;   DEPRECATED-FUNCTION-WARNING: Using deprecated function BDEF::BDEF-REF -- please update your code to use a newer API.
;   The docstring for this function says:
;   Deprecated alias for `find-bdef'.
;   
...
Unhandled UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001BFC103}>: COMPILE-FILE-ERROR while compiling #<CL-SOURCE-FILE "bdef/cl-patterns" "cl-patterns">

bdef/tests fails to build because of a failure in bdef/cl-patterns.

Full log here

The test uses undocumented-symbols, which was defined in "mutility", but is now in "mutility/test-helpers", so it is undefined.

Adding "mutility/test-helpers" to the :depned-on of "bdef/tests" fixes it, but it is probably better to put undocumented-symbols back in "mutility" itself.

After the fix it errors with undocumented symbols:
(*BDEF-TEMPORARY-DIRECTORY* SPLITS-FROM-OP-1-DRUMSET BDEF-ID BDEF-KEY)

Building with SBCL 2.0.9.5-442f54894 / ASDF 3.3.1 for quicklisp dist creation.

Commit id 954ed51

bdef/incudine fails to build with the following error:

Unhandled ASDF/FIND-COMPONENT:MISSING-DEPENDENCY in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001A50103}>: Component #:INCUDINE not found, required by #<SYSTEM "bdef/incudine">

Full log here