deepsourcecorp / good-first-issue Goto Github PK

Description

A malicious actor can gain full control over the user's DOM window object. As such, this can lead to phishing attacks such as fake login prompts or password alerts being shown to the user. <!--more--> Using target='_blank' links grants the page we are linking to a partial access to the …

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/deepsourcelabs/good-first-issue/issue/JS-0712/occurrences/

Outline:

• What is a good first issue?
• For project maintainers: how to create good first issues?
• For contributors: how to find an issue to get started?

The content should be live at: /guide/what-is-good-first-issue

There is no tag for swift. Moreover, links with special-chars are not working!

Originally posted by @mayank-genesis in #53 (comment)

This will help all the new members to know how to contribute and what are the objectives :)

I would like to contribute by creating a PR to add variations of labels like good-first-issue and :wave: Good First Issue that I am seeing being used in some open source projects. There is also a related issue #278.

From what I understand, I just need to add the new labels to labels.json file. But wanted to check if there is a way to run the application locally to check.

I ran the following commands:

• make pre-build
• make build

but got the error:
FATAL Cannot find module './data/tags.json'

Some repositories don't have the label good-first-issue, but they have labels good-first-bug or good first issue. Therefore, the list of good first issues on the web is lacking. For example, https://github.com/ogham/exa/issues?q=is%3Aissue+is%3Aopen+label%3Agood-first-bug. To query all possible results, we should query by regex pattern, like good.*first.*[issue/bug] instead of a hardcoded value: good-first-issue

A filter on the right or the left would be nice.

Hi,

Under the Browse by language section, there is a tag with count 3 but nothing written in it,

When you click on it, a 404 page not found response is thrown.

Prevent the CI build from passing and block the merge if there are duplicates listed in data/repositories.toml.

A page to guide new open-source contributors. This could include (but not limited to) commit best practices, pull request conventions, seeking help, picking a good first issue, code review etiquette, etc.

Currently we're displaying repos which have no issues at all. This needs to be fixed.

Real-time search on owner, name, and language.

Hi,

I was looking into the repositories while scrolling I can see 2 results for same Microsoft /vscode.

Again at,

While the first link works fine the second one does nothing.

It will be valuable to write guides and how-tos around good first issues and open-source contributions. This can be implemented using Nuxt Content, and the guides can be written using Markdown.

Project like Peertube added an emojii in their label for beginners like "good first issue 🔰"

Right now there is some issues labeled with this label but they don't appears on the goodFirstIssue listing. :(

I asked the same on Peertube folks side if just removing the emoji could help but maybe striping emoji at beginning/end of the label is not that bad.

19:18:41.089  
Traceback (most recent call last):
19:18:41.089  
  File "gfi/populate.py", line 139, in <module>
19:18:41.089  
    repo_details = get_repository_info(repo_dict["owner"], repo_dict["name"])
19:18:41.089  
  File "gfi/populate.py", line 92, in get_repository_info
19:18:41.089  
    info["description"] = emojize(repository.description)
19:18:41.089  
  File "/vercel/.cache/pypoetry/virtualenvs/good-first-issue-YXUa6MG0-py3.6/lib/python3.6/site-packages/emoji/core.py", line 52, in emojize
19:18:41.089  
    return pattern.sub(replace, string)
19:18:41.089  
TypeError: expected string or bytes-like object

This is causing #71.

Since hacktoberfest is going to start soon, it will be really helpful for the beginners if they can find all the hacktoberfest labelled issues as well on gfi.

We can however add a certain mark (maybe a star or a label next to the issue title as Github does) which can help them differentiate issues labelled as hacktoberfest from the ones labelled as good-first-issue.

I added Apache Superset a couple weeks ago, but don't see it reflected in the goodfirstissue.dev website. Is there something else needed to to be done to deploy the website?

i added my volder npm package , you see it in pull request
link to the repo:https://github.com/devSupporters/volder

This can be ignored as it should not be version controlled.

I'll make a PR about this.

Hi,
In browse by Language is 2 tag and one is blank (i.e x3 &
Emacs Lisp x3)

Pointing To the 404 page not Found.

Any Suggestion if someone has I would Like to Work.

Currently the website displays the repositories in a really long list. I was wondering if I can take up the challenge of adding a feature where the user can select a way to sort the list.
After that maybe features like, filtering and searching as well.

It would be great to have https://gitlab.com to be a source for the repositories where everyone can contribute.
There are a lot of open source and widely used projects that are open for accepting contributions.

If I filter repositories selecting "C#" language, the results displayed are for "C" language (the url that I'm redirected to is https://goodfirstissue.dev/language/c)

For ex: easy pickings, E-easy, etc.

To be added to file: https://github.com/deepsourcelabs/good-first-issue/blob/master/data/labels.json

From #54 by @RJ722

The way we query the GitHub API right now:

https://github.com/deepsourcelabs/good-first-issue/blob/82c11219150d60eefc33396201d5a8fea9b0fc41/gfi/populate.py#L79-L85

We do a logical AND for all the labels supplied from the data/labels.json. We'd need to change that to search for issues having any one, or more of the labels supplied.

I plan to fix it.

Move labels to labels.json file under data directory.

This would enable us to add more beginner issue tags like easy-pickings, E-easy, etc.

Some projects are archived and there's no point of listing them anymore. I guess they have been added in the past and they were being actively maintained at the time they were added, but as of today when you list #javascript you get 105 results and the first one is Josh's guppy project which is already archived. So it would be better if they are filtered out in my opinion.

In one of my repositories, I ran a deepsource analysis and in one of the autofix sessions, it creates a buggy PR.

Style: Unnecessary parentheses after keyword PYL-C0325

ifresult is None:
    print("This won't be printed, because NameError: name 'ifresult' is not defined")

The last activity data on cards do not match with the ones in repos (last commit).

One repo I checked had the last commit from 17 months ago but on the website, it showed the last activity as 2 days.

Twitter handle: @gfidev

1. Although "good first issue" is the default label that GitHub encourages projects to tag for issues suitable for newcomers, many projects prefer to use other labels, such as "beginner", "easy" and "first timer only". Maybe other labels can be considered in the first criterion.
2. Perhaps a clearer description of "actively maintained" is needed. Vague descriptions may damage the objectivity of the last criterion.

I found some project that match the criteria to be added but have variations of the good first issue labels like good-first-issue and :wave: Good First Issue I would like to add these label variations and subsequently add these repos.

Example:

• https://github.com/JetBrains/Exposed/issues?q=is%3Aopen+is%3Aissue+label%3Agood-first-issue
• https://github.com/apollographql/apollo-kotlin/issues?q=is%3Aopen+is%3Aissue+label%3A%22%3Awave%3A+Good+First+Issue%22

I assume that adding these labels to labels.json would be sufficient.

I find the website very useful. Something that would increase the value of the website for me would be to see the number of comments attached to each issue. This would save me time in knowing which issues I'm interested in viewing.

I would just add the feature and PR, but I have no idea how to get the project running locally.

If someone could help me get the project running locally, I could add the feature myself.

Thanks.

Hi @jai-deepsource @siddhant-deepsource
Currently there are two different pages to handle the display and filtering of repos

1. language/index.vue
2. language/_slug.vue

as both the pages were almost doing the same thing and handling the filter repos by label using language/_slug.vue is adding limitations, code repetition and complexity to support features like multi label select and deselect to filter the repos.

Propose solution

1. instead it would be much better if we can handle these things in language/index.vue page by adding a new state to maintain the active tag or label selected (example: javascript) and filter the repos accordingly if there is any active tag or tags. else all the repos can be displayed.
2. remove language/_slug.vue page and it's dependent code.

i can raise a PR for this if this sounds reasonable to you guys

Demo:

Note: I have suggested this solution as per my understanding on the project but please let me know if i'm missing anything or if there are any complications with my approach

Thank you!

The Exposed repo has 11 issues with good-first-issue

Right now new repositories are added at the end of the list, and it causes git conflicts when couple PR are on the way. Requirement to have the list sorted will almost remove these conflicts.

I picked up a Kotlin good first issue in the mockk repo. 🎉 Thanks for providing this service.

But I noticed that there are only four repos for Kotlin. Another library I use has three good first issue: https://github.com/detekt/detekt/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

I was wondering if only repo owners can add new repos or others can add repos too?

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Here is a screenshot:

Maybe add a white background?

The apollo-kotlin repo has 4 issues with :wave: Good First Issue label. Depends on #394.

It is not clear how someone can set GFI up locally and start local development. There should also be fixtures so the user doesn't need to run the population themselves.

Hi
there is error Coming in:
good-first-issue/gfi/tweet.py
Line -18 => LOGGING_CONFIG
Line-22,23,24 => Import error (Unable to Import toml)

Currently, the order of the repos is the same as defined in the config file. This can bury new repos down in the UI.

Description

It is recommended to use arrow functions as callbacks.

Occurrences

There are 4 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/deepsourcelabs/good-first-issue/issue/JS-0241/occurrences/