Git Product home page Git Product logo

algebrain's People

Contributors

dedoussis avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

algebrain's Issues

Transformation example doesn't work

Hey! Not sure if you're still working on this project, but the Transformation example in the readme doesn't seem to be working. I get:

The 15th term of fibonacci is:
fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+
fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+
fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+
fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+
fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+
fib(-1)+fib(-2)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+fib(-1)+fib(-1)+fib(-2)+...

Canonical form

https://github.com/dedoussis/algebrain/blob/master/src/nodes.ts#L147

Expected:
Canonical form should respect non commutative operator symbols
For example:

Algebrain.parse("x^4").canonical().toString()
> "x^4"

Algebrain.parse("x*4").canonical().toString()
> "4*x"

Actual:
Canonical form does not respect non commutative operator symbols
For example:

Algebrain.parse("x^4").canonical().toString()
> "4^x"

Signed atom operator

Unary operator does not behave as expected.

Expected:

> -x
Operator {value: "-", children: [Symbol { "x" }])} 

Actual:

> -x
Symbol { value: "x" } 

Flat operator node before evaluating

Context:
x+1+5 when parsed generates a nested tree with + as the root node, and x+1 as one of the leafs. Given that all the expression operands share the same OperatorSymbol.PLUS operator, the expression can get flat and evaluated
At the moment x+1+5evaluates to x+1+5.

Solution:
+(+(x,1), 5) should become flat: +(x,1,5), which will allow the evaluation to x+6

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.