decipherinc / angular-debaser Goto Github PK

Use with npm/browserify? I noticed that private is set to true in the package.json file. Would you publish this to npm and support CommonJS?

it's shorter and pretty obvious.

pretty sure I built in support for this sort of thing. the Sinon functions are all aliased to func so should not be a rabbit hole.

this should be pretty easy

obviously some sort of misconfiguration, but I'm going to have to track down where exactly it came from. this may have been an errant grunt gh-pages against an old branch.

how to mock functions that return promise?

I've discovered an issue in my code where the first object to be declared in a debaser chain is not stubbed:

beforeEach(function () {
      debaser()
          .module('lander')
          .object('$location', {first: "first"})
          .object('$window', { lander_gon: { searchKeywords: "Test Keyword", searchLocation: "Test City" }, location: { replace: sinon.stub() } })
          .debase();
    });

logging these objects from the application code shows that $location is the actual implementation:

Tb {$$protocol: "http", $$host: "server", $$port: 80, $$parse: function, $$compose: function…}

However, if I add any other declaration before it:

    beforeEach(function () {
      debaser()
          .module('lander')
          .object('$location', {first: "first"})
          .object('$location', {second: "second"})
          .object('$window', { lander_gon: { searchKeywords: "Test Keyword", searchLocation: "Test City" }, location: { replace: sinon.stub() } })
          .debase();
    });

I get:

 Object {second: "second"}

This is not limited to the location object (I first noticed it with $window).

This is occurring with Jasmine 2.0.2, angular-debaser 0.3.2

I'm kicking myself for not filling out the description before, but I believe what's happening is if you stub an existing module, and provide a constant with the name of an existing constant, you get the real one.

We need a lot of docstrings to get the API documentation (jsdoc) usable.

I don't really dig on the constant api:

// module with constant object bar
module('foo').withObject('bar', {baz: 'quux'})

We don't need explicit modules. anonymous modules are fine. we should just be able to provide:

1. constantObject() convenience method
2. constantFunc() convenience method
3. constant() method which has more power
4. potentially an options parameter to func and object in which you can define either of these as constants

Current version of PhantomJS (1.9.7) doesn't support Function.prototype.bind yet:
ariya/phantomjs#10522

so debaser fails with:

TypeError: 'undefined' is not a function (evaluating 'function run() {
              this.next.apply(this, arguments);
            }.bind(this)')
        at runner (.../lib/angular-debaser/debaser.js:604)

Getting a 404 error over there.

I wonder if there's a way to run the tests using Jasmine and Mocha+Chai easily. The syntax is slightly different, of course, and I'm not sure how well the Sinon assertions will hold up.

autoScope option needs tests