When installing on windows without node-gyp, installation fails because of a dependency on sha3 (a binary npm package). There is a pure javascript implementation of this called js-sha3 which might fix this dependency.

The cli depends on the commons, and because of this dependency (and also secp256k1), we are unable to install without requiring a full build environment on windows.

If it's possible to replace these sub-dependencies with pure javascript versions, it will mean that our windows users will only have to install node (a 16mb binary) and everything will work. Requiring node-gyp and a build environment means installing python and visual studio.

[email protected] /Users/ben/Contracts/dcl/commons
└─┬ [email protected] (git+https://github.com/decentraland/provider-engine.git#00eabad4c2a09698e23f44d811aec3e662c11841)
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └── [email protected] 

We're already implementing a super simple version of env here

We should add a function like isBrowser() -- so that we can check REACT_APP_NODE_ENV so we know where to look for when checking if we are in dev or prod

I think it might be useful to have the doc html pages deployed as GH pages.

To do this we should serve the result of running npm run docs, which saves everything on a out folder. We'll also need to update it with every tag (or major change)

It looks like this:

What do you think?

We should be able to remove keys like:

• bytecode
• deployedBytecode
• sourceMap
• deployedSourceMap
• source
• sourcePath

from every artifact to reduce the bundle size

Specification found here: decentraland/marketplace#10

We're currenly not supporting strings with , inside of them because the implementation does not enforce wrapping strings with "".
We should also enforce the max length of name and description

Motivation:

I want to call connect as:

web3Eth.connect()

or

web3Eth.connect({
  contracts: [Contract1, Contract2]
})

or

web3Eth.connect({
  contracts: [Contract1, Contract2],
  defaultAddress: '0x627303090abaB3Aae1400e9345bC63c78a8BEf57'
  httpProviderUrl: 'https://ropsten.infura.io'
})

API for connect could be:

async connect(options = {}) { ... }

We must need to adapt the implementation of the new method signature

Discussing with @menduz about using the lib on https://github.com/decentraland/client, we may want to get rid of the babel and babel-polyfill dependency from this library.

Check https://github.com/decentraland/marketplace/blob/master/webapp/src/modules/wallet/utils.js#L3

connect will throw an error if contracts parameter is undefined.

It would be great to set a default empty array at the method firm:
async connect(defaultAccount, contracts = [], options = {})

Or check if contracts are undefined here before looping them.

The motivation is to call eth.connect()