deanebarker / episerver-dynamic-templates Goto Github PK

The DynamicTemplatesResolver is an injected service, so this could be changed at the implementation level. But an argument could be made that a dedicated tab should be the default.

The code in "the Template property" (see parenthetical under Step 6 of the demo install guidelines), needs to be encapsulated in a custom property. Currently, the property looks like this:

public virtual ContentArea Template
{
    get
    {
        var localValue = this.GetPropertyValue(p => p.Template);
        var locator = ServiceLocator.Current.GetInstance<IDynamicTemplateResolver>();
        return locator.GetTemplate(localValue, this);
    }
    set { this.SetPropertyValue(p => p.Template, value); }
}

If this was a custom property, there are two benefits:

1. The code is encapsulated so it doesn't have to be copied and pasted. If we make improvements in the future, properties would have to be manually updated.
2. This property could be assigned via the UI, which means editors could create new content types from the UI, and template them. Since the code has to be copied into a content model file right now, modeling has to be code-first

The ITemplatingService has a couple of methods that expose TemplateContext, which is a Fluid-specific type. This really defeats the purpose of DI. These need to be removed so that interface isn't implementation-specific.

It should be possible for the editors to use regular on-page-edit for the properties even though they are shown through a template.

When editors use the templates, they have to type in the names of the source properties. It would be much nicer, if they could pick them from a list.