ddddxxx / lyricsx Goto Github PK

View Code? Open in Web Editor NEW

4.5K 58.0 375.0 25.21 MB

🎶 Ultimate lyrics app for macOS.

License: Mozilla Public License 2.0

Swift 97.63% Rich Text Format 2.29% Shell 0.08%

lyrics itunes spotify vox menubar download-lyrics apple-music audirvana swinsian macos-app

lyricsx's People

Contributors

Stargazers

Watchers

Forkers

aygs chyiz gabrielpeart vansteven s2339956 kwokpingl chagge liam-i breezehome songyafei seakeylife gitter-badger tarycheung zhouchang714 wangxufire jizhang27 face-sea gayhubuser yjpark sunset-knight jn7163 yangchenghu yuanbin-xavier luoshihui peterdocter syncyourmind chyi341152 sunyruru zengqingbo kahboom sjsurf 1364566531 whycloser appdirectory thevenomsnake yhbyun sealiu karandeepdps bradparks weiqiangzheng ikishorek ianliu0 rangolee cococ0j asing1001 volzkzg muisish hamandeikun 3158zhan kevinyzy dev4shane sissifeng yamidaisuke jevade guyemmer softowaha freshy969 incidunt doanabi haxine deamwork jason-4-github pushbox n00017007 harry-jk fabianomarechal abuzzworld icestraw ijoeychang ypl6 resslerruntime junyukuang chinnsenn tarsbase inrtgdje han111 ruanrenjie inboxs eamon39 solitongas microdustor build-yellow-padding double517 johndpope hexd2019 blackrosevil iigmir datasone ax1951 wade1990 yellowfour satarii gangmon ekodedypurnomo mystars5656 skuaka hdlaocai acid-chicken aloptrbl ddyyff

lyricsx's Issues

希望能够设置网络代理开关

有时候开了代理的时候搜索不到歌词，十分麻烦，希望能够在设置中增添不使用代理的选项。

better search result sorting

Compare result with keyword using levenshtein distance.

display lyrics on Multi-Touch Bar

进程CPU占用率略高

播放器关闭时占用率在11% 12%左右
播放器打开播放歌曲时占用率大约在18%~25%之间，觉得有些高
rmbp mid2015 i7

有些国外歌手无法搜索到歌词

像Ed Sheeran的歌就不行(翻译成艾德·希兰)，但是Adele(翻译成阿黛尔)的歌就可以正常搜索到。
同时在菜单栏点击搜索歌词会崩溃
crash.txt

能否添加标记错误歌词的功能呢？谢谢！

由于歌词是自动下载，当一首歌没有匹配的歌词（比如OST）的时情况下，自动下载下来的歌词都是错误的，但是又没有标记错误歌词的功能，导致错误的歌词只能一直显示，或是只能临时关闭app
请问能否添加标记错误歌词的功能呢？谢谢！

Karaoke lyrics window do not work on MacBook 2011

The karaoke lyrics window is showing on my imac, but not on my macbook pro.

support earlier version of macOS

LyricsX currently support macOS 10.12 or later.

cannot search lyrics for Up&Up - Coldplay

& is not a valid character

sandbox violation for user defined lyrics saving path after program restart

I believe this is not a regression, but has been there for a while.
I set my lyrics saving path to a different location, and it worked fine for that program session. But if I restart the program, it's not able to read and write my lyrics folder anymore, and I got sandbox violation messages in my console.

I tried to debug the program, and found that at least url.startAccessingSecurityScopedResource() in Extension.swift:91 still returns true. So I'm out of ideas.

preference preset

Save current preference as a preset, and quick switch presets from status menu.

建议在顶部菜单栏显示歌词的时候，隐藏 LyricsX 图标

建议在顶部菜单栏显示歌词的时候，隐藏 LyricsX 图标，这样可以节省宝贵的菜单栏空间

切换桌面时菜单栏歌词不显示

切换桌面时发现菜单栏的歌词不显示了，切回到之前的桌面也不会显示，只有关闭菜单栏显示功能再重新打开才可以。
后来发现好像是有chrome的桌面，然后滚动下chrome的页面，歌词就不显示了。

对于国区Apple Music里部分歌曲歌词识别有误

国区Apple music中部分国外歌手的名字进行了中文翻译，所以导致搜索结果有偏差
比如https://itun.es/cn/2upzdb?i=1130689910
建议歌词搜索算法进行调整

[feature request]希望能自己设定歌词位置

超级感谢开发！这个比dynamic lyrics好用多了！

唯一美中不足的就是之前一直习惯把歌词放在桌面右下角，并且单行显示，现在变成了中间两行非常不习惯，希望能自己设定歌词显示位置和行数。

再次感谢！

首选音乐播放器设为自动时不能随播放器自动启动和退出

如题所示，问题所在。
系统版本是：10.12.4 (16E195)

增加捐赠方式

cannot add lyrics filter key

support Spotify

跟随播放器启动和退出无效

需要手动退出和启动（试了 iTunes 和 VOX）。

退出后LyricsX进程不见，LyricsXHelper 没有出现。

music player hot-switching

do not show lyrics when no lyric is matched.

Some songs or melodies don't have lyrics or lyrics are not matched.
When this happened, it is better to offer an option to hide the lyrics.

不能跟随iTunes启动

我安装LyricsX以后不能跟随iTunes启动，设置里选择的是iTunes，点选了跟随播放器启动和退出。打开iTunes播放音乐以后还是不启动，需要手动打开。退出iTunes时可以跟随播放器一起退出。我的Mac OS 10.12.5，iTunes 12.6.1.25。

cannot write .lrc file to default saving path

due to the app sandbox, access "~/Music/LyricsX" directly is not permitted.

LyricsX prevent music player quit

music player will be re-opened immediately.

iTunes 打开时，LyricsX 不能启动

设置随 iTunes 启动退出无效，且在 iTunes 打开时，LyricsX 不能启动

V1.1.1 Menu Bar 歌词无法显示

左为V1.1.0 右为V1.1.1

support Vox

LyricsX crash while player is stopped

bridging NSString? to String? crash.

试试看vox能不能用

好像好少人用呀,做吃螃蟹的第一人吧,效果到时再说!!

auto launch & quit with iTunes

LRC file do not save properly

LRC file name associate with search info, not song info. therefore, if search info was modified, LRC file will not save properly.

Please Adjust Priority of Lyrics Services Source

For 163 providing the lyrics with Chinese translated lyrics, it would be much better to select the lyric from 163 instead of Xiami.
Or maybe you could allow us to change the priority

Spotify Beatles 的基本全部不同步

4 首歌 3 首不同步：Yesterday、Hey Jude、Let It be。Ticket To Ride 可以显示歌词。

现在这样子几乎没办法用。

lyricsScrollView.highlight() may crash the main thread while called during track change

Looks like when lyricsScrollView.highlight() is trying to set the highlight to the textView, the content may be updated by setupTextContents() at the same time. I guess if the new lyrics was shorter, then the range in lyricsScrollView.highlight() would be invalid.

It only happens during a track change not initiated by the user. When this crash happens, the lyrics view will stuck and no longer scroll with the music.

Here is the stack trace from the crash:

2017-04-15 01:01:37.041082-0400 LyricsX[72652:27527528] [General] NSMutableRLEArray objectAtIndex:effectiveRange:: Out of bounds
2017-04-15 01:01:37.043947-0400 LyricsX[72652:27527528] [General] (
	0   CoreFoundation                      0x00007fff77a8637b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00007fff8c87a48d objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff77b04c3d +[NSException raise:format:] + 205
	3   Foundation                          0x00007fff79438f73 -[NSRLEArray objectAtIndex:effectiveRange:] + 136
	4   Foundation                          0x00007fff79438e43 -[NSConcreteMutableAttributedString addAttribute:value:range:] + 241
	5   UIFoundation                        0x00007fff8a69145c __NSConcreteTextStorageLockedForwarding + 49
	6   UIFoundation                        0x00007fff8a6917b8 -[NSConcreteTextStorage addAttribute:value:range:] + 84
	7   LyricsX                             0x0000000100029c80 _TFC7LyricsX16ScrollLyricsView9highlightfT8positionSd_T_ + 1312
	8   LyricsX                             0x000000010000d214 _TFC7LyricsX23LyricsHUDViewController20handlePositionChangefV10Foundation12NotificationT_ + 1268
	9   LyricsX                             0x000000010000daf7 _TToFC7LyricsX23LyricsHUDViewController20handlePositionChangefV10Foundation12NotificationT_ + 71
	10  CoreFoundation                      0x00007fff77a1250c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
	11  CoreFoundation                      0x00007fff77a1240b _CFXRegistrationPost + 427
	12  CoreFoundation                      0x00007fff77a12172 ___CFXNotificationPost_block_invoke + 50
	13  CoreFoundation                      0x00007fff779cf5a3 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1827
	14  CoreFoundation                      0x00007fff779ce5dc _CFXNotificationPost + 604
	15  Foundation                          0x00007fff793f2997 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
	16  LyricsX                             0x0000000100082e4b _TFC7LyricsX13AppController21playerPositionChangedfT8positionSd_T_ + 2395
	17  LyricsX                             0x0000000100084cd9 _TTWC7LyricsX13AppControllerS_19MusicPlayerDelegateS_FS1_21playerPositionChangedfT8positionSd_T_ + 73
	18  LyricsX                             0x0000000100077d15 _TFC7LyricsX18MusicPlayerManagerP33_56E704B12050AFB21D960AB4D9E4115A20updatePlayerPositionfT_T_ + 805
	19  LyricsX                             0x00000001000748af _TFFC7LyricsX18MusicPlayerManagercFT_S0_U0_FCSo5TimerT_ + 127
	20  LyricsX                             0x000000010007490c _TTRXFo_oCSo5Timer__XFdCb_dS___ + 60
	21  Foundation                          0x00007fff7948ef3f __NSFireTimer + 83
	22  CoreFoundation                      0x00007fff77a05d04 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
	23  CoreFoundation                      0x00007fff77a0598f __CFRunLoopDoTimer + 1071
	24  CoreFoundation                      0x00007fff77a054ea __CFRunLoopDoTimers + 298
	25  CoreFoundation                      0x00007fff779fcc31 __CFRunLoopRun + 2065
	26  CoreFoundation                      0x00007fff779fc1c4 CFRunLoopRunSpecific + 420
	27  HIToolbox                           0x00007fff76f5debc RunCurrentEventLoopInMode + 240
	28  HIToolbox                           0x00007fff76f5dcf1 ReceiveNextEventCommon + 432
	29  HIToolbox                           0x00007fff76f5db26 _BlockUntilNextEventMatchingListInModeWithFilter + 71
	30  AppKit                              0x00007fff754f8e24 _DPSNextEvent + 1120
	31  AppKit                              0x00007fff75c7485e -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796
	32  AppKit                              0x00007fff754ed7ab -[NSApplication run] + 926
	33  AppKit                              0x00007fff754b81de NSApplicationMain + 1237
	34  LyricsX                             0x000000010003078d main + 13
	35  libdyld.dylib                       0x00007fff8d15f235 start + 1
)

MP3 链接: https://pan.baidu.com/s/1pKWznJ1 密码: 3rxb