Otserver closing out of nowhere, no warnings about forgottenserver-orts HOT 22 CLOSED

http://otland.net/threads/10-31-the-forgotten-server-1-0-915.207351

Try using that one, found one aswell that made it crash, changed to that exe and it workes without any problems at all.

from forgottenserver-orts.

Gonna try that out and i'll send an answer afterwards here

from forgottenserver-orts.

Well, just tried it, it took longer to get down but still it went, like 10 minutes after.

from forgottenserver-orts.

Humm could you write to me on otland and ill take a look over teamviwer. You must have changed something since you are the only one with this problem.
Otland = WibbenZ

from forgottenserver-orts.

I have started investigating that problem since I got the same one. I started by looking in the crashdump that I had to manually set up in regedit... Turns out that the error is connected to the NPC function onThink().

I don't know exactly what goes wrong, but you are most welcome to look into it. I can think of two things:

1. the npc xml files don't have the xml header declared (found a few example where it wasn't declared)
2. there is something wrong with the underlying lua scripts for one or several npcs.

The sad part is that it takes 15 minutes for the server to crash. But after a couple of hours playing around with the xml files and such I added a header to all xml files and changed their scripts to default.lua, and the server is running steady after 50 minutes.

I will continue trying to find out what the problem is. But please feel free to help me!

from forgottenserver-orts.

Can you provide us with the fixes NPCs? Só I van try to ser if that works for me

from forgottenserver-orts.

http://www.speedyshare.com/r2B2z/npc.rar

just copy replace the whole npc folder with this one (make sure to backup your old one first)

also, this npc folder is not from the most up to date version found here on github, instead it's from last weeks repo, but should work anyway

from forgottenserver-orts.

though I should say, you can't use the npcs ingame because I changed their behaviour to that of a default npc :) it's just about figuring out the npc(s) that is(are) wrong!

from forgottenserver-orts.

So its just for testing? If i use then they wont do what they are firstly suposed to do?

from forgottenserver-orts.

no it's not a fix, just for testing yes. one or several of the xml files / lua files are not set up correctly, it seems. so it's all about turning on and off the npcs until you found all the errors...

from forgottenserver-orts.

Its kinda bizzarre because I use the npvs folder from global on my ot that is not running global mal and it didnt crash at all

from forgottenserver-orts.

so then we know that someting is wrong with any/several of the lua/xml files

my guess is:

1. king tibianus lua script has functions listed twice
2. a majestic wolf lua script contains xml code and not lua code
3. other lua scripts not setup correctly

from forgottenserver-orts.

Yeah well.. Those NPCs does not respawn in my ot, so it you might be right

from forgottenserver-orts.

gonna go to sleep now but I can conclude that excluding king tibianus and changing majestic wolf lua as well as adding headers to all xml-files did not solve the error. So there must be additional lua code that is wrong!

from forgottenserver-orts.

Some NPCs perhaps, bit i van say that all from yalahar are working

from forgottenserver-orts.

Then I would try the "Addon 9.60" NPC, Nahlesar, Chester Kahs(spelling?), THe Orc King

will continue tomorrow!

from forgottenserver-orts.

Sure! Thanks for the idea, im gonna try that

from forgottenserver-orts.

Did you try to replace the npc folder to the newset rev?

from forgottenserver-orts.

yes, I have found the npc scripts that's causing the error:

Alexander
Ariella
Arito
Aruda
Ashtamor
Baxter
Beatrice
Nahlesar
Towncryer

All these have "special" onThink() functions that gives out some kind of unexpected result for the server after 10-15 minutes.

Or it might also be that it never reaches NpcHandler:onThink()

regular npc-setup looks like

function onThink()
npcHandler:onThink()
end

but these have functions like:

function onThink()
if ((os.time() - yell_delay) >= frequency) then
yell_delay = os.time()
doCreatureSay(getNpcCid(), YELL[math.random(#YELL)], 1)
end
npcHandler:onThink()
end

I'm not that good at scripting but I'd say yell_delay is uninitialized when it's used, and uninitialized variables throw an exception in x64 but can be handled win32 as far as I've read. Also debug mode handles these kinds of exceptions, that's why the server doesn't crash in debug mode...

This is one of the most annoying bugs that can happen when shifting from win32 to x64!

from forgottenserver-orts.

Also, since I've spent some time looking at the npc-script there are alot of them that have small errors.
Maybe it's better if I fix the pull request when I have time? (tomorrow)

from forgottenserver-orts.

Let me take a look first, someone must have done a change on the npcs in that case, my server is stable running.

When did you download this npc pack?
Write to me on otland and ill give you my skype so we can try to figger this out.
Wibbenz

from forgottenserver-orts.

Okey so I've found what crashed my server, in Nahlesar.lua, in the onThink() function, at the bottom, it says "return true", erase that line and the crashed will hopefully stop!

from forgottenserver-orts.