daylerees / dependency-injection-example Goto Github PK

Hi,
I'm newbie to TDD so my appologize for that question, but shouldn't we write test for Twitter like for Facebook?
public function testSocialFeedCanBeInstantiated() { $t = M::mock('Example\FeedReaders\FacebookFeedReader'); $s = new SocialFeed($t); }

public function testSocialFeedCanBeInstantiated2() { $t = M::mock('Example\FeedReaders\TwitterFeedReader'); $s = new SocialFeed($t); }

Thanks to the great tutorials!
I noticed a mistake in your code

https://github.com/daylerees/dependency-injection-example/blob/master/part-9/tests/SocialFeedTest.php#L41

        $this->assertEquals($v[0], 'foo');
        $this->assertEquals($v[1], 'bar');
        $this->assertEquals($v[2], 'baz');
        $this->assertEquals($v[3], 'boo');
        $this->assertEquals($v[4], 'bop');

In PHPUnit (as well as all xUnit frameworks) the first argument in assertion is expected, and second is actual. So you should flip this code to look like:

        $this->assertEquals('foo', $v[0]);

The require in mockery\mockery\tests\Bootstrap.php line 79 should be require_once, this was causing fatal errors.