davidicus / create-iot-react-app Goto Github PK

Here's a list of issues I ran across when using the create-iot-react-app.

1. I think yarn is required. The docks sounded like npm could be using instead. That should be documented somewhere (or just use yarn in the docs so it is implied more).

2. I think the node version required is 10.15.3.
   I had node 9.11.2 installed and when I ran it I got error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got "9.11.2".
   When I installed the latest node version and ran it, I got `error [email protected]: The engine "node" is incompatible with this module. Expected version "10.15.3". Got "12.16.3"

3. Hit javascript heap max memory when doing yarn build. FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory.
   I had to export env var NODE_OPTIONS=--max-old-space-size=4096 in order to get build working.

CRA has released v4.

This package could update to use the newest version which includes nice improvements such as faster reloads and jest v26.

Update readme to include usage instructions and feature list

Spin up a new app via npx and the automatically installed version of d3 is "d3": "^6.2.0", causes this error

Failed to compile.

./node_modules/@carbon/charts/components/axes/grid-brush.js
Attempted import error: 'event' is not exported from 'd3-selection'.

This version of d3 is incompatible with carbon-charts.

carbon-design-system/carbon-charts#775

It needs to be the same version range they define in their peer deps

https://github.com/carbon-design-system/carbon-charts/blob/master/packages/core/package.json#L58

"d3": ">=5.0.0 <=5.14.2"

Identified in carbon-addons-iot-react - this just needs to include d3 as an installed dep

carbon-design-system/carbon-addons-iot-react#1062

Could the output of this package include a basic cypress testing set up with a few basic tests?

It seems pretty straightforward https://medium.com/swlh/add-cypress-tests-to-your-react-app-75f7a8e1f18b

Sniff babel-loader version number to use for install so that we are installing the one that is compatible with CRA. It currently uses an older version so we have to install whatever one needed.

issue is complete when:

• we can sniff version number of babel-loader module that CRA uses
• we install the sniffed version

I get the following error when running yarn start:

Failed to compile.

./src/index.js
Module not found: Can't resolve './serviceWorker' in 'C:\src\carbon\iot3\src'

If I comment out the following line in index.js, everything seems to work properly:

import * as serviceWorker from './serviceWorker';

Running in Windows 10 with Node v12.18.1 (also tried in Linux with Node v14)

Sass partials from the carbon-addon-iot-react package are not resolving properly. This is an issue with the addons package but wanted to record as an issue here since it is a dep.