davidbrowaeys / dxb Goto Github PK

Create a new command to align the API versions of each component in a project to the API version defined in sfdx-project.json.

It can be executed with dxb:api:align.

This enhancement plans to upgrade the existing packages to the latest version in the package.json.
There is a chance that changes included in this issue will require command line arguments to be changed.

It appears that the fs.readdirSync function behaves inconsistently in terms of sorting as shown in these links:
https://stackoverflow.com/a/51890207/8797514
nodejs/node#3232

This causes problems when running sfdx dxb:profile:build between developers who use different operating systems.

Is it possible to sort the arrays after calling fs.readdirSync, or allow this option by passing in an argument? Please let me know if you require more clarification.

Running dxb:permissionset:clean fails on a permission set with recordTypeVisibilities tags with the following error:

TypeError: result.PermissionSet.recordTypeVisibilities.filter is not a function

I was poking around in here and saw this

which seems like it's gonna be painful over time.

May I suggest seeing if something from here might be helpful?
https://github.com/forcedotcom/source-deploy-retrieve/blob/main/src/registry/metadataRegistry.json
https://github.com/forcedotcom/source-deploy-retrieve/blob/main/src/registry/registryAccess.ts

Steps to reproduce:

1. Create a custom metadata type in a scratch org.
2. Assign permissions to the custom metadata type to the profile.
3. Pull the profile changes into your source code.
4. Run sfdx dxb:profile:convert.

Expected Result:

A JSON file containing the custom metadata type is created.

Actual Result:

No JSON file containing the custom metadata type is created.

Note: An example of the profile permission are as follows:

...
<customMetadataTypeAccesses>
    <enabled>true</enabled>
    <name>Some_Custom_Metadata__mdt</name>
</customMetadataTypeAccesses>
...

When I run sfdx dxb:profile:convert, it appears that only one of Case and CaseClose layout assignments are persisted. My guess is that layout assignment permissions are parsed based on record type. This works fine for every object except for Cases because Cases have layout assignments for both Case and CaseClose despite having the same record type.

Below is an example of valid metadata even though they both have the same recordType.

<layoutAssignments>
    <layout>Case-Case Layout</layout>
    <recordType>Case.Some_Record_Type</recordType>
</layoutAssignments>
<layoutAssignments>
    <layout>CaseClose-Close Case Layout</layout>
    <recordType>Case.Some_Record_Type</recordType>
</layoutAssignments>

Please let me know if you have any questions.