david-woroniuk / historic_crypto Goto Github PK

Nice work, thank you.

BTC-USD is a valid ticker, however, currently WBTC-USD, BTC-USDT and BTC-USDC are also found.
By adding the regex=True parameter, you could now specify ^BTC-USD$ to just get BTC-USD.

I'll send a PR.

Coinbase Pro is shutting down and migrating to Coinbase Advanced. This needs to be updated to use Coinbase Advanced.

I think requests should be called with multithreading/asyncio instead of like so:

Could you elaborate on why you're doing it this way? Has this got something to with rate limits?

It would be nice if there was an option to pull data from the earliest available start date. Is there a way to do that?

I'm trying to set a cut off point for the data retrieval. However, end_date seems to have no effect at all.

Here is my script

import datetime
from Historic_Crypto import HistoricalData



delta = datetime.timedelta(weeks=3)

date_now = datetime.datetime.now()
        
end_date = date_now - delta
end_date = end_date.strftime("%Y-%m-%d-%H-%M")


df = HistoricalData('BTC-USD', 86400, '2014-01-01-00-00', end_date).retrieve_data()
print(df.tail())

I was trying to use the code you put on your PyPI page and I got an error: AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

the error was leading to code line 176 in HistoricalData.py and I found that if you change the line to:

data = pd.concat([dataset])

it solves the error. maybe you should look into this error a little bit and if possible fix it because I'm sure many people would try your library, see it doesn't work, and give up and look for another library. Thank You in advance

This is a very useful module. Unfortunately, the PiPy version seems to be older and there is no setup.py, so pip can install with -e.

This is unpleasant, as correcting it might break the API. However, it should be addressed, as your module is very useful and will be used in the future.

You might do a deprecation warning in first and announce breaking changes once you bump to 1.0 remove the old name.

If you are interested, I could try to address this.

Hello, thanks for your work.
I might have found an odd behaviour.
It seems that with a single chunk or two chunks, the time order changes.
See

import datetime

from Historic_Crypto import HistoricalData

signal = 'ETH-EUR'
granularity = 86400
days = 300 # try 300 or 301
date_start = (datetime.datetime.now() - datetime.timedelta(days + 1)).strftime('%Y-%m-%d-00-00')
date_end = (datetime.datetime.now() - datetime.timedelta(1)).strftime('%Y-%m-%d-00-00')

print(HistoricalData(signal, granularity, date_start, date_end).retrieve_data(), signal)

As in the comment, try with 300 (single chunk) and 300 (two chunkes)
300 => from new to old
301 => from old to new

opening PR for fix

Why does HistoricalData().retrieve_data() return different values depending on the granularity input?