david-truong / liferay-workspace Goto Github PK

The com.liferay.workspace:1.0.2 does not copy configs into the ZIP bundle, neither from common/ or {environment}/.

Not sure if this is the place, but there is no issues tab in the repo where the plugin is present (https://github.com/liferay/liferay-portal/tree/master/modules/sdk/gradle-plugins-workspace).

Hi David,

I saw that in recent commit, you changed the way how the Liferay bundle is fetched, from Maven-based properties (groupId, artifactId, version + repo url) to simply URL pointing to zip: 922958f

I was wondering, are there any plans to allow authentication to be used with fetching the bundle? For Liferay Workspace EE, we will very likely need to get EE bundle from some restricted locations (Maven repository, ftp etc.) so I was wondering if you plan to add support for this in the base Liferay Workspace.

I though about it and I think the simplest would be to use the older Maven-based configuration and allow Liferay Workspace users to define additional repository in their Gradle build, and make sure it will be tried to get the bundle. Users can then use whatever authentication they want (as long as it will be supported by Gradle for given repository).

Another possibility would be to add new configuration keys for to gradle.properties recognized by the Workspace plugin (username & password) and use them to fetch the bundle.url if they are provided.

The modules/extensions/sample-model-listener cannot be compiled, seems like the API in Liferay 7.0.0 has recently changed, the exception class being moved:

liferay/liferay-portal@3a42d59

Compilation produces following error:

:modules:extensions:sample-model-listener:compileJava
/opt/devel/liferay/github/lfrgs-liferay-ironman.master/liferay-build-tool/liferay-workspace-gs/build/liferay-workspace-DistBundleSpec-1454946448420/modules/extensions/sample-model-listener/src/main/java/sample/model/listener/CustomLayoutListener.java:5: error: cannot find symbol
import com.liferay.portal.ModelListenerException;
                         ^
  symbol:   class ModelListenerException
  location: package com.liferay.portal
/opt/devel/liferay/github/lfrgs-liferay-ironman.master/liferay-build-tool/liferay-workspace-gs/build/liferay-workspace-DistBundleSpec-1454946448420/modules/extensions/sample-model-listener/src/main/java/sample/model/listener/CustomLayoutListener.java:19: error: cannot find symbol
        throws ModelListenerException {
               ^
  symbol:   class ModelListenerException
  location: class CustomLayoutListener
2 errors
:modules:extensions:sample-model-listener:compileJava FAILED

It would be good if the names of these folders were read from a gradle.properties and we could provide the defaults

gradle.properties

modulesFolder=modules
themesFolder=themes
pluginsSDKFolder=plugins-sdk

and these could support nesting too

modulesFolder=folder/with/nesting/modules