liferay-workspace's People
Forkers
gamerson lovettli andywu2015 sustacek lawrence-lee aperrelli yanan davidrison ermakovmaxim hhuijserliferay-workspace's Issues
Configs are not copied into bundle ZIP
The com.liferay.workspace:1.0.2
does not copy configs into the ZIP bundle, neither from common/
or {environment}/
.
Not sure if this is the place, but there is no issues tab in the repo where the plugin is present (https://github.com/liferay/liferay-portal/tree/master/modules/sdk/gradle-plugins-workspace).
Authentication for Liferay bundle fetching
Hi David,
I saw that in recent commit, you changed the way how the Liferay bundle is fetched, from Maven-based properties (groupId, artifactId, version + repo url) to simply URL pointing to zip: 922958f
I was wondering, are there any plans to allow authentication to be used with fetching the bundle? For Liferay Workspace EE, we will very likely need to get EE bundle from some restricted locations (Maven repository, ftp etc.) so I was wondering if you plan to add support for this in the base Liferay Workspace.
I though about it and I think the simplest would be to use the older Maven-based configuration and allow Liferay Workspace users to define additional repository in their Gradle build, and make sure it will be tried to get the bundle. Users can then use whatever authentication they want (as long as it will be supported by Gradle for given repository).
Another possibility would be to add new configuration keys for to gradle.properties recognized by the Workspace plugin (username & password) and use them to fetch the bundle.url
if they are provided.
Cannot compile sample-model-listener
The modules/extensions/sample-model-listener cannot be compiled, seems like the API in Liferay 7.0.0 has recently changed, the exception class being moved:
liferay/liferay-portal@3a42d59
Compilation produces following error:
:modules:extensions:sample-model-listener:compileJava
/opt/devel/liferay/github/lfrgs-liferay-ironman.master/liferay-build-tool/liferay-workspace-gs/build/liferay-workspace-DistBundleSpec-1454946448420/modules/extensions/sample-model-listener/src/main/java/sample/model/listener/CustomLayoutListener.java:5: error: cannot find symbol
import com.liferay.portal.ModelListenerException;
^
symbol: class ModelListenerException
location: package com.liferay.portal
/opt/devel/liferay/github/lfrgs-liferay-ironman.master/liferay-build-tool/liferay-workspace-gs/build/liferay-workspace-DistBundleSpec-1454946448420/modules/extensions/sample-model-listener/src/main/java/sample/model/listener/CustomLayoutListener.java:19: error: cannot find symbol
throws ModelListenerException {
^
symbol: class ModelListenerException
location: class CustomLayoutListener
2 errors
:modules:extensions:sample-model-listener:compileJava FAILED
Allow the "special" names of "modules", "themes", and "plugins-sdk" be configurable
It would be good if the names of these folders were read from a gradle.properties and we could provide the defaults
gradle.properties
modulesFolder=modules
themesFolder=themes
pluginsSDKFolder=plugins-sdk
and these could support nesting too
modulesFolder=folder/with/nesting/modules
need to ignore node_modules in workspace gitignore
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.