davetapley / dingr Goto Github PK

For all incomplete tunes, find the missing notes for the best version we have for each.

Show how many players are used in a song, and when multiple matches are available for a tune, list the one with the most players used first.

Once a song is matched, identify the players used in each song version.

On show page show each player alongside note.
Perhaps group them by color, per #3.

Need to find a good way of timing them up with the notes.

Perhaps a string for each note chunk (see #3).

Set a player unavailable to exclude them for tune computation

When displaying same notes consecutively in a tune, we should chunk them together in a box and/or color, so it's clear.

The player/note could then be shown with the corresponding color.

Instead of assigning colors to players randomly for each song, a player should be able to choose their color from a pool of those maximally distant from other colors.

Find a way to figure out which bell notes we are missing from each song, so that we can potentially find the right bell for it.

Two parts:

• Hide tunes which are incomplete from the main page.
• From a tunes admin page we should be able to nominate which versions of a tune are shown.

Once #15 is done it'd be nice to 'pin' specific versions to the tune page.
Once pinned they will always be shown, regardless of whether a player is available (per #13).

When ever we show the notes for a song, group them in to their time signature.
Can assume 4/4 for now.

Can just store it as a '-' in Tune#notes.
Disregard them in Tune#match_notes.

We're trying to display tunes in a time signature (since #1), but we need note length.

I propose all notes are implicitly semibreves, but we may prefix a note with -. This note would be handled as normal, but could be used as a placeholder to indicate that two notes actually form a breve, thus:

C4 C4, is two semibreves.
C4 -C4 is a breve.

Currently tune versions are ID by their index in the array returned by match_notes.
These IDs aren't canonical, and can prevent a user viewing a transpose unless it's a complete (or the current 'best') match.

Probably add notes/rests first.
Then render a note chunked version (#3) and have a text field for each chunk.

/tune/:id/version/:lowest_semitone

This means we can render any tune, even if we don't have enough player bells for it.