Git Product home page Git Product logo

cmp1903_a1_2324's People

Contributors

markdoughty avatar

cmp1903_a1_2324's Issues

Code Review

Negatives:
Testing class was not functional
Some small errors in the Game and Die classes which had to be fixed before the code could be run
Some methods should be changed to follow PascalCase as specified by the style guidelines
Private fields should be changed to follow _camelCase as specified by the style guidelines

Positives:
Once some errors had been fixed, both the Game and Die classes seem to function correctly without crashing
Invalid user inputs are well handled to allow the user to continue using the program
Code is well commented to provide understanding to less obvious functions
Methods, fields and properties and local variables are well named making the code easily readable

review a code

yes the code functions as intended, you could add more encapsulate in the die class.yes, code is formatted in accordance to the guidelines.
yes, code is clear and the comments help clear up confusions.and all the errors are handle in a good manner way.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.