Git Product home page Git Product logo

commandminerewards's People

Contributors

byswiizen avatar datatags avatar deepsource-io[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

byswiizen

commandminerewards's Issues

Option to only give one reward on each time

I have already:

[X] Updated to the latest version of CMR. https://www.spigotmc.org/resources/commandminerewards.27316/
[X] Put CMR into debug mode and read the log for clues (see bottom of the resource page for step-by-step)
[X ] Included config.yml and debug.log in the issue in a .zip file. (Hint: drag and drop the .zip from File Explorer into this box.)

Description of issue

Sometimes I get none rewards, sometimes I get multiple. I am trying to use this plugin as a lucky block plugin and it works pretty damn good without the issue in the title

Debug: https://pastebin.com/HMFFZywu
Config: https://pastebin.com/G103ST4T

Thank you in advance for making this plugin. It is great

I use Paperspigot 1.12.2 :)

Players not getting rewards

how do i use title in config rewards
I have this doubt

commands:
- cmr special title &test &6tester&b+ 10 20 10
console: This command can only be used by a player!

Performance sucks

(This issue was reported by SpigotMC user @FuturePinger. Mainly creating an issue so I don't forget.)

Description of issue

Pretty self-explanatory. Probably mostly caused by apparently rebuilding the ENTIRE blocks list EVERY time the block break event is called?
Every time block break is called we loop over GlobalConfigManager's getBlockHandlers
getBlockHandlers rebuilds a list of matching blocks every time it's called

To fix, we should probably:

  1. Keep a cache of blocks and handlers, probably a HashMap that is loaded when the plugin starts.
  2. Split it up into at least a couple methods, it's really long and the indentation is out of control.

A bunch of the plugin was rewritten a while back to be more future-proof from itself but not all of it got rewritten, which is probably how this happened.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.