Git Product home page Git Product logo

Comments (2)

martindurant avatar martindurant commented on August 14, 2024

I agree, it is reasonable that fastparquet should not close a file-like object if that has been passed. It should not be hard to code - would you like a go?

On the other hand, it's also pretty easy to make a file-like object that cannot be closed

class UnclosableBytesIO(io.BytesIO):
    def close(self):
        pass

buffer = UnclosableBytesIO()

from fastparquet.

avyfain avatar avyfain commented on August 14, 2024

This indeed seems like inconsistent behavior across engines:

>>> import io
>>> import pandas as pd
>>>
>>> data = [{"x": 1, "y": 2}, {"x": 2, "y": 3}]
>>> df = pd.DataFrame.from_records(data)
>>> 
>>> buffer = io.BytesIO()
>>> df.to_parquet(buffer, engine="fastparquet")
>>> print(buffer.closed)
True
>>> buffer.getvalue() 
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: I/O operation on closed file.

vs

>>> buffer2 = io.BytesIO()
>>> df.to_parquet(buffer2) # using the default pyarrow
>>> print(buffer2.closed)
False
>>> buffer2.getvalue() 
b'PAR1\x15\x04\x15 ...

Thanks for the workaround @martindurant.

from fastparquet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.