Git Product home page Git Product logo

Comments (4)

martindurant avatar martindurant commented on September 17, 2024

Thanks for letting me know, I'll look into it.

from fastparquet.

martindurant avatar martindurant commented on September 17, 2024

As far as I can tell, no released version of pandas supports numpy 2 yet (I see 2.2.2, and https://github.com/pandas-dev/pandas/blob/main/environment.yml#L26 ) - should this issue wait until that is resolved? Dev versions of pandas do use numpy2, but rebuilding that seems too much.

from fastparquet.

bnavigator avatar bnavigator commented on September 17, 2024

environment.yml is not relevant here. The only relevant lines are in pyproject.toml:

https://github.com/pandas-dev/pandas/blob/v2.2.2/pyproject.toml#L11
https://github.com/pandas-dev/pandas/blob/d9cdd2ee5a58015ef6f4d15c7226110c9aab8140/pyproject.toml#L30-L32

and from the changelog:
https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0

Pandas 2.2.2 is the first version of pandas that is generally compatible with the upcoming numpy 2.0 release, and wheels for pandas 2.2.2 will work with both numpy 1.x and 2.x.

The pandas 2.2.2 wheels published on PyPI were compiled with numpy 2, so pandas itself works with numpy 2. A few optional extra dependencies are not compatible yet, but these should not be relevant for the test cases in question.

from fastparquet.

bnavigator avatar bnavigator commented on September 17, 2024

Besides, this is not a failure related to pandas, but rather to a change in numpy type promotion:
https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion

fastparquet/fastparquet/converted_types.py

Lines 159 to 162 in ec26733

data2 = data.view([('ns', 'i8'), ('day', 'i4')])
# TODO: this should be ms unit, now that we can?
return ((data2['day'] - 2440588) * 86400000000000 +
data2['ns']).view('M8[ns]')

from fastparquet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.