Git Product home page Git Product logo

Comments (3)

martindurant avatar martindurant commented on August 14, 2024 1

I think you are right, and your use case of a few very long strings hasn't typically come up. I'm not sure parquet is a particularly optimised storage format for that. In any case, it should not cause a copy and memory spike.
However, I don't think that .astype(str) should make a fixed-length array, or indeed any copy at all in normal circumstances. Is there something else special about your data? It may also depend on pandas version.

All that being said, I don't see any downside to using .str.len(), so I would welcome a PR with this change.

from fastparquet.

martindurant avatar martindurant commented on August 14, 2024

Actually, I think I stand corrected, and pandas will tend to copy unless one were to explicitly opt against it, and the dtype matches exactly (and str is not object). Only this is fast:

x.astype(x.dtype, copy=False)

(as it doesn't really do anything) and everything else requires copies.

from fastparquet.

mshober avatar mshober commented on August 14, 2024

While the response of pd.Series(["value"], dtype="string").astype(str) is a Series of dtypeobject, under the hood this operation is creating a numpy unicode array at some point. Not sure why Pandas does that; I may open up a ticket with Pandas too just to make sure that's not a bug. Looks like this issue does not occur for Pandas 2.0

from fastparquet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.