dashpay / bls-signatures Goto Github PK

Hi I noticed that the version of this library that is being used does not include the shamir secret stuff so I was wondering what the difference is between how the quorums work today in threshold? Is it migrating to another model?

When compiling on gcc 12 (Fedora 36) we need to include the following header for this to build.

https://github.com/dashpay/bls-signatures/blob/main/src/threshold.cpp#L6

#include <memory>

Verified this issue and fix on v1.2.0.

I have the following error:

/usr/bin/ar: /usr/lib/libgmp.so: file format not recognized make[2]: *** [src/CMakeFiles/combined_custom.dir/build.make:73: src/CMakeFiles/combined_custom] Error 1

IOW, the make file tries to extract obj files from libgmp.so and libsodium.so into distinct directories and end up recombining all the extracted obj files into a big combined_custom archive.

I have manually edited the Makefile to skip over the steps that were manipulating the so files as if they were archives.

Any idea why the Makefiles expect static libs for gmp and sodium?

Is my fix ok? I am building bls-signatures as a prerequisite to build dash-core. Am I going to be bitten back by having removed libgmp.a and libsodioum.a from combined_custom archive? Where is combined_custom being used?

Thank you

the building proccess on ARM64 ubuntu-21.10 failed while compiling test.cpp
and generated error: messages from the gcc compiler.
please fix the problem sir...

First noted in #43 (comment)

Almost every PR after #43 has 1 or 2 failing jobs.

I created a relatively simple program that just creates a private key from a seed and then exports the seed, private key, and public key as hex, but it doesn't compile due to this error:

go run cmd/dashmsg/main.go bls generate

# github.com/dashpay/bls-signatures/go-bindings
blschia.cpp:17:10: fatal error: 'bls-dash/bls.hpp' file not found

Obviously this doesn't work with the standard Go build process. What custom steps are necessary to get this to work?