dasch-swiss / dsp-das Goto Github PK
View Code? Open in Web Editor NEWDaSCH application suite for the DaSCH Service Platform
Home Page: https://docs.dasch.swiss/latest/DSP-APP/
License: Apache License 2.0
DaSCH application suite for the DaSCH Service Platform
Home Page: https://docs.dasch.swiss/latest/DSP-APP/
License: Apache License 2.0
Perform user testing to improve the current user interface and complete the user guide. Gaby, Martin Mattmüller (BEOL)?, Regula and the Lausanne will be part of this testing phase.
Describe the bug
I get warnings about incorrect peer dependency while running yarn install --prod=false
To Reproduce
Run yarn install --prod=false
Expected behavior
This is the output:
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/[email protected]".
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/[email protected]".
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/[email protected]".
Additional context
We should try to update the angular version from 8.2.4 to 8.3.x or higher
Is your feature request related to a problem? Please describe.
In users list in system view, we prepared a menu item to add user to a project directly. This feature is not yet implemented.
Describe the solution you'd like
Extend this feature with a list of projects, where the user is already member of and with the possibility to remove user from a specific project. Better menu label: "Manage project membership"
Describe alternatives you've considered
N.A.
Additional context
N.A.
Is your feature request related to a problem? Please describe.
No problem.
Describe the solution you'd like
Spotted on KUIRL (prod server)
Edit content: add website links to the logos (DaSCH, UniBasel, UniL...) + add a better description for each public project (e.g. the description of BEOL project is a non-serious draft that any user can have access to...)
Describe alternatives you've considered
N.A.
Additional context
N.A
Describe the bug
The position of mat-menu in the list is wrong when this is the last item (it does not appear) or when the menu appears at the bottom of the screen (it's cropped or appears far away from the button). The shadow effect surrounding the div is also missing.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
The mat-menu should appear close by the button (on the top or bottom or left). The box-shadow should be visible.
Additional context
N.A.
Is your feature request related to a problem? Please describe.
There is currently no link from the Kuirl User Guide to the web app, and from the web app to Kuirl User Guide.
Describe the solution you'd like
Add a visible link to the doc and the web app to link each other.
Describe alternatives you've considered
N.A.
Additional context
These links will be needed by the user testers during the user testing phase.
Is your feature request related to a problem? Please describe.
The label "Edit profile" should be shorten.
Describe the solution you'd like
the label "Edit" only in user profile view should be enough.
Describe alternatives you've considered
N.A.
Additional context
N.A.
Is your feature request related to a problem? Please describe.
A system admin shouldn't be able to remove himself as a system admin.
Describe the solution you'd like
Disable menu item in list of users.
Describe the bug
After login the user will be redirected to the previous page and by logout it refreshes the current page. This could be problematic in case of restricted resources. And there's a problem with encoding, because it encodes twice.
To Reproduce
Full-text search: Ein Ding für jemanden
--> API request: http://0.0.0.0:3333/v2/search/Ein%20Ding%20f%C3%BCr%20jemanden?offset=0
Not logged-in
{
"@id" : "http://rdfh.ch/0000/forbiddenResource",
"@type" : "knora-api:ForbiddenResource",
"knora-api:arkUrl" : {
"@type" : "xsd:anyURI",
"@value" : "http://0.0.0.0:3336/ark:/72163/1/0000/forbiddenResourceV"
},
"knora-api:attachedToProject" : {
"@id" : "http://www.knora.org/ontology/knora-admin#SystemProject"
},
"knora-api:attachedToUser" : {
"@id" : "http://rdfh.ch/users/root"
},
"knora-api:creationDate" : {
"@type" : "xsd:dateTimeStamp",
"@value" : "2017-10-06T11:05:37Z"
},
"knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|V knora-admin:UnknownUser",
"knora-api:userHasPermission" : "V",
"knora-api:versionArkUrl" : {
"@type" : "xsd:anyURI",
"@value" : "http://0.0.0.0:3336/ark:/72163/1/0000/forbiddenResourceV.20171006T110537Z"
},
"rdfs:label" : "This resource is a proxy for a resource you are not allowed to see (may depend on the context: query path)",
"@context" : {
"rdf" : "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
"rdfs" : "http://www.w3.org/2000/01/rdf-schema#",
"xsd" : "http://www.w3.org/2001/XMLSchema#",
"knora-api" : "http://api.knora.org/ontology/knora-api/v2#"
}
}
Logged-in
{
"@id" : "http://rdfh.ch/0001/a-thing-with-text-values",
"@type" : "anything:Thing",
"knora-api:arkUrl" : {
"@type" : "xsd:anyURI",
"@value" : "http://0.0.0.0:3336/ark:/72163/1/0001/a=thing=with=text=valuesv"
},
"knora-api:attachedToProject" : {
"@id" : "http://rdfh.ch/projects/0001"
},
"knora-api:attachedToUser" : {
"@id" : "http://rdfh.ch/users/9XBCrDV3SRa7kS1WwynB4Q"
},
"knora-api:creationDate" : {
"@type" : "xsd:dateTimeStamp",
"@value" : "2016-03-02T15:05:10Z"
},
"knora-api:hasPermissions" : "CR knora-admin:Creator|V knora-admin:ProjectMember",
"knora-api:userHasPermission" : "CR",
"knora-api:versionArkUrl" : {
"@type" : "xsd:anyURI",
"@value" : "http://0.0.0.0:3336/ark:/72163/1/0001/a=thing=with=text=valuesv.20160302T150510Z"
},
"rdfs:label" : "Ein Ding für jemanden, dem die Dinge gefallen",
"@context" : {
"rdf" : "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
"knora-api" : "http://api.knora.org/ontology/knora-api/v2#",
"rdfs" : "http://www.w3.org/2000/01/rdf-schema#",
"xsd" : "http://www.w3.org/2001/XMLSchema#",
"anything" : "http://0.0.0.0:3333/ontology/0001/anything/v2#"
}
}
Open the resource from search results:
Not logged-in
--> API-request: http://0.0.0.0:3333/v2/resources/http%3A%2F%2Frdfh.ch%2F0000%2FforbiddenResource
Logged-in
--> API-request:
http://0.0.0.0:3333/v2/resources/http%3A%2F%2Frdfh.ch%2F0001%2Fa-thing-with-text-values
Expected behavior
The main issue is in the search results. When a user is not logged-in he gets results with restricted resources. By opening one of them it shows the forbidden resource (type: knora-api:ForbiddenResource). The user presses the login button, the login page opens incl. the return-url parameter. After successful login the user will be redirected to the previous url. In case of the search result the user should get the correct resources and not the forbidden one anymore. In case of the resource view, it doesn't work as suspected because when the not-logged-in user opens a forbidden resource and he logs-in, it's still the iri of the forbidden resource. This is something we can't solve quite easy.
Screenshots
Not logged-in:
URL: http://localhost:4200/search/fulltext/Ein%20Ding%20f%C3%BCr%20jemanden
After login, redirected by return-url parameter:
URL: http://localhost:4200/search/fulltext/Ein%2520Ding%2520f%25C3%25BCr%2520jemanden
By comparing the two URLs, the second one was encoded again. There's an issue with the returnUrl parameter.
Version:
The resource classes and properties created in the ontology-editor should be editable.
Knora should give the info of which field is editable and enable/disable template fields accordingly.
Is your feature request related to a problem? Please describe.
Only system admins can add users to any projects. But the project admin should be allowed to do the same for their projects.
Describe the solution you'd like
A project admin can add existing users in its projects. System admin can keep the privilege to create a new user.
Describe alternatives you've considered
N.A.
Additional context
Spotted during the drafting of the test protocol document.
Is your feature request related to a problem? Please describe.
I understood that in KUIRL the search results could already be sorted using selected properties. But I can't see how (I was using your test server and KUIRL v.1.3.0)
Describe the solution you'd like
In the screenshot, I would have expected to click either on Date de creation
or Emplacement
(just like I would on a column header in a speadsheet) to be able to sort the search results alternatively by creation date or location. But it is not yet possible to do so, right?
Is your feature request related to a problem? Please describe.
"Delete user" can still login to the web app.
Describe the solution you'd like
Describe alternatives you've considered
N.A.
Additional context
N.A.
Describe the bug
Change (not own) user's password has an issue at the end of the form.
There's still "Next" button.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No button
Screenshots
N.A.
Additional context
N.A.
Is your feature request related to a problem? Please describe.
You have to start Knora in addition to starting Kuirl
Describe the solution you'd like
a docker-compose.yml which pulls a latest Knora and a latest Kuirl docker image from dockerhub, this file should already have all environments set so that all parts of the stack work together without any necessary further actions.. This would enable the user to start Knora, a triplestore and Kuirl and possible Sipi and maybe a key-value store with only one comment.
Describe alternatives you've considered
I don't know of any alternative, but maybe Kuirl can be added to the docker-compose file in the Knora - Repo?
When checking the Knora-App Hopepage, I am not really sure, what the overall purpose of the page there is in my eyes a too large variety of information and services combined in one set:
The general Layout design is quite nice, but the content should be more structured to clear information packages and easily navigatable positions . And I would really like less scrolling to find out what else is on the page.
To Reproduce Steps to reproduce the behavior:
OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (drag-and-drop the image directly here).
Desktop (please complete the following information):
OS: Windows 10 Pro N, 1903 - 18362.418
Browser Google Chrome, 78.0.3904.87
Version Knora App, 1.6.2
Additional context
Add any other context about the problem here.
Describe the bug
The login failed when I try to log in with either a user member or a system admin account in Safari.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Login and redirect to the dashboard or the ongoing search url.
Desktop (please complete the following information):
Additional context
I have tried the same process with 3 different branches: master, documentation-link and fix-issue-85.
Describe the bug
As project admin or system admin, it is not possible to reactivate a suspended user in a project. Only the action "Remove user from project" is available in the user action menu.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A project admin or a system admin should be able to reactivate a user.
Desktop (please complete the following information):
Additional context
N.A.
Describe the bug
The collaborators information are not well displayed in the list. There is also an error with the icons (see screen shots).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Information well displayed.
Desktop (please complete the following information):
Additional context
N.A.
Is your feature request related to a problem? Please describe.
Where do we store the search queries / templates? What‘s about the resource collections? Is the knora-team able to expand the admin storage e.g. collection and search template (close to the user profile) OR do we have to implement an additional database?
Describe the solution you'd like
We can use the the key-value-store in Knora but it's not yet implemented. At the moment we can experiment with localStorage which is also kind of key-value-store...
Describe alternatives you've considered
MongoDB
Additional context
N.A.
Is your feature request related to a problem? Please describe.
In the next release (2019-09) it's possible to create lists and add new item. But there's no possibility yet to edit or delete list items or to reorder them.
Describe the solution you'd like
Update list-item-form to edit.
Additional context
This feature needs the implementation of the StringLiteral form component to support multi-language inputs. I already started with a prototype of this form in knora-ui-playground
Expected situation:
I saw on the user guide that the name Skuirl has already been adopted!! So, if it is actually the case, any title/label Kuirl on the app should be changed to Skuirl.
Is your feature request related to a problem? Please describe.
The packages of jdnconvertiblecalendar and jdnconvertiblecalendaradapter are not up-to-date. Warnings are thrown during yarn install
.
Describe the solution you'd like
Update the packages to jdnconvertiblecalendar and jdnconvertiblecalendaradapter
Describe alternatives you've considered
N.A.
Additional context
N.A.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
!! Error tested only for the members Admin Webern
and Nutzer Webern
.
Expected behavior
Display the member project membership form or disable this functionality for this member.
Desktop (please complete the following information):
Smartphone (please complete the following information):
N.A.
Additional context
N.A.
When I navigate in the knora-App, I would be able to move easily back to the initial page. Unfortunately I cannot find a button "Home"
To Reproduce Steps to reproduce the behavior:
OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (drag-and-drop the image directly here).
Desktop (please complete the following information):
OS: Windows 10 Pro N, 1903 - 18362.418
Browser Google Chrome, 78.0.3904.87
Version Knora App, 1.6.2
Additional context
related to #211
Route added in Knora-API: dasch-swiss/dsp-api#1421
Describe the bug
The position of the buttons Reset and Search of the expert search bar is wrong.
Expected behavior
The buttons must be in the expansion-panel after the textarea input.
Probable cause of the bug
The position "absolute" of the css class in knora-ui search module, expert-search component is not adapted for this layout.
Is your feature request related to a problem? Please describe.
When we have to edit a resource, we edit the single property fields. For them we already have form elements in knora-ui viewer and search module. We have to combine them in viewer. And we need additional form fields like a richtext-editor.
Describe the solution you'd like
For the richtext-editor I just found this nice article: How to Add Rich Text Editor to an Angular App with Localization
https://medium.com/@hohanga/how-to-add-rich-text-editor-to-an-angular-app-with-localization-ecc7f7238294
Describe alternatives you've considered
The article is about CK-editor which we already used in Salsah. There was no other editor who fulfilled our conditions. Probably there are other ones, but we should try with CK-editor again
Describe the bug
After adding a new user, the user doesn't exist in the autocomplete list of project collaboration.
To Reproduce
Steps to reproduce the behavior:
Additional context
By adding new user, we should update the cached list of users
Is your feature request related to a problem? Please describe.
The user profile does not contain all the information about the user.
Describe the solution you'd like
In addition to the name, username and default language, the email address and the user role should be displayed as well. The user role would be only a chip tag indicating if you are System Admin.
Describe alternatives you've considered
N.A.
Additional context
N.A.
Describe the bug
When I create a new list, with a label and description, first in my default language (my user language, english for example) and then in German and French. The label and description displayed in the accordion menu are in German and not in English.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The default language should be displayed instead of the German version all the time.
Additional context
N.A.
After moving the repo from dhlab-basel to dasch-swiss and after moving the user guide out of code we have to clean up as follow:
Implement the ontology editor.
To create an ontology, add resources classes, add properties to a class, edit.
Get group or a list of groups.
Create a group.
Edit a group.
I tried to find the Version of the System. I expected it in a menu "Info" or similar like in other software.
Only with help from Flavie I found out, that the Verion information is in an one of those boxes but below the visible website part.
I would wish for less text, boxes and such on that page, but prezise 1-line information with links to further information. That way all I need to see I can do without scrolling...
To Reproduce Steps to reproduce the behavior:
OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (drag-and-drop the image directly here).
Desktop (please complete the following information):
OS: Windows 10 Pro N, 1903 - 18362.418
Browser Google Chrome, 78.0.3904.87
Version Knora App, 1.6.2
Additional context
Add any other context about the problem here.
Describe the bug
The design of KUIRL is not responsive on phone format.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Responsiveness
Screenshots
N.A.
Smartphone (please complete the following information):
All smartphone format, all browsers.
Additional context
Tablet version has already been fixed.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:
OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (drag-and-drop the image directly here).
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
On project and user profile page:
Is your feature request related to a problem? Please describe.
It's unclear in which project or ontology the resource belongs to, especially when we do full text search in All Projects.
Describe the solution you'd like
Display the name of the project and/or the ontology in the resource view, at the top of the page.
Describe alternatives you've considered
N.A.
Additional context
-> how can we know this resource comes from BEOL?
For Angular, adding Bazel should be fairly straightforward: https://angular.io/guide/bazel
Is your feature request related to a problem? Please describe.
After a discussion with @subotic this morning we should extend project info by defining main resource class of the project which will be displayed after project information on page like app2.dasch.swiss/project/0803
Describe the solution you'd like
A project admin can define an advanced search, which will run by open project page. But instead of storing gravsearch as a string, we should define an intermediate layer in proper json. Something like:
{
"ontology": "iriOfOntology",
"resource-class": "iriOfResClass",
"properties": [
{
"property-type": "iriOfPropertyType",
"comparison-operator": "=",
"value": ""
},
...
]
}
We can use the advanced search to create and store this object. A service will convert it into gravsearch and we are able to list some resources to give a guest user additional context about a project.
Additional context
This is already and as well a first step into the modular project-specific publication part of the app. I will start with a simple example and make a proof of concept.
Is your feature request related to a problem? Please describe.
There is a section with DaSCH contact information in the footer of the logged-out homepage but there is nothing in the logged-in part.
Describe the solution you'd like
Contact information should be added on the dashboard or in the user menu > tab e.g."Need help" or "Contact DaSCH" or something equivalent.
Describe alternatives you've considered
Contact form.
Additional context
N.A.
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
all users list: add chip to indicate who is system-admin and add menu item to add or remove user from system admin group
Additional context
At the moment, we don't get the information about system admin in the list of users from Knora API s. Issue #1315
Is your feature request related to a problem? Please describe.
A common feedback we get from Salsah 1.5 is that the search results are somewhat frustrating. Because even if they look like a table, which is great, you can't sort the results according to the properties you passed as parameters for the query.
For now, the search results in Knora-app are not displayed in the form of a table.
Describe the solution you'd like
TextValue
, DateValue
, etc.).Describe alternatives you've considered
Additional context
Here is an example for https://boccacciocommedia.unil.ch/varianti.php .
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.