daryltucker / magiclessquotes Goto Github PK

Allow Users to decide whether or not MagiclessQuotes runs on save.

We should be able to replace different characters for different filetypes/extensions.

Allow Users to blacklist specific files they wish MagiclessQuotes to ignore.

When the file reloads after save, it loses the cursor position.

I was writing a shell script (file type in Sublime = Shell Script (Bash)) and whenever I tried to write:

FILE=`cat /tmp/file`

MagiclessQuotes would, upon saving the file, convert it to:

FILE='cat /tmp/file'

Allow the User to modify their User Settings to reflect custom changes. Ideally, our System Settings/Package Settings will have minimal character replacement and allow the User to easily extend what is replaced.

I'm running ST3 3070 with a bunch of plugins (is there a way to list those for debugging purposes?). In any case, when I save the following text:

Alas, as much as I try to understand other people’s perspectives, the first reference to my "male privilege”—my privilege!—is approximately where I get off the train, because it’s so alien to my actual lived experience. This is not, insanely, to suggest a lack of misogyny in the modern world! To whatever extent there is misogyny, one could say that there’s also "male privilege.” Rather it’s to suggest that, given what nerdy males have themselves had to endure in life, shaming them over their "male privilege” is a bad way to begin a conversation with them.

You can see it messes up on the mdashes:

Alas, as much as I try to understand other people's perspectives, the first reference to my "male priv---lege"—my pr---vilege!—is approximately where I get off the train, because it's so alien to my actual lived experience. This is not, insanely, to suggest a lack of misogyny in the modern world! To whatever extent there is misogyny, one could say that there's also "male privilege." Rather it's to suggest that, given what nerdy males have themselves had to endure in life, shaming them over their "male privilege" is a bad way to begin a conversation with them.

@daryltucker - I moved this conversation from the package control issue over here.

I'd be happy to work with you to improve MagiclessQuotes so we don't end up with redundant packages floating around. It didn't occur to me to reach out to you first when we found your package wasn't quote working for us.

There are only a few issues that are of concern - let me know what your thoughts are on these:

1. The ability to run via menu command, rather than on-save because in the workflow we use, we need to see what the changes look like before committing to them
2. Related, some feedback as to how many (or eventually what and where) replacements were made
3. Replacing more character types (see my repo for the list we came up with)
4. Looking for more extended unicode variations

Thanks!

Allow the User to select a key-combo (Keybindings - User) to run at his or her will.

After running MagiclessQuotes, the user should be presented with a console message giving them a list of changes and totals/results.

@dhirsch

@theJoeBiz has offered a patch and it seems to be working for me. I just wanted to ask you to see if the changes are working nicely for you, or if they cause any issues.

Thanks.

I've got some PHP code where I have strings such as:

  '0066b4b2' => array(
    'http://test.com/',
    'Bob & Alex'
  ),
  '68a33207' => array(
    'https://www.youtube.com',
    'Rich & Steve'
  ),

When I save the file, this gets changed to:

  '0066b4b2' => array(
    'http://test.com/',
    'Bob & Alex'
  ),
  '68a33207' => array(
    'https://www.youtube.com',
    ' & h & Steve'
  ),

Ampersands are not smart quotes, and they're within a string, so I'm not sure why this is happening.