darwinye / tab-organizer Goto Github PK

Especially in terms of whitespace. I think the amount of whitespace between 
<li> items should be increased, for instance. Small stuff like that, to improve 
readability.

What steps will reproduce the problem?
1. Open the popup.
2. Change some options.
3. Look at the popup.

What is the expected output? What do you see instead?
The options should be changed immediately. Instead, I need to refresh the popup 
before the changes take place.

Please provide any additional information below.
Some options we can't really change while the popup is loaded. However here is 
the list of things we can change, but don't:

* popup.type
* tabs.close.display
* usage-tracking

The problem with changing "popup.type" is that a user may not like having Tab 
Organizer automatically close and then reopen itself when they merely wanted to 
change the option.

The problem with "tabs.close.display" is that it would probably require adding 
a "change" event to every tab. This is really bad because that would mean that 
every time any option changes, it needs to trigger once for each tab!

One hack we could try is to add a single "change" event, that grabs all the 
close buttons and then changes them. That would avoid a lot of the performance 
costs, but could be a tad tricky to implement.

The problem with "usage-tracking" is that I'm not sure if it's even possible to 
stop Google Analytics without a page refresh.

What steps will reproduce the problem?
1. Create a new window.

What is the expected output? What do you see instead?
The Remover page should automatically remove itself, instead it stays open. 
Occasionally, it will even remove tabs that it shouldn't!

Please provide any additional information below.
This is especially noticeable when undoing an action that causes multiple 
windows to open at once.

We have a bunch of unit tests for the Options API, but we need a lot more. In 
particular, unit tests that deal with synchronization issues between frames.

What steps will reproduce the problem?
1. Open Tab Organizer.
2. Middle click on a tab.

What is the expected output? What do you see instead?
Tab should be closed. Instead, nothing happens.

Please provide any additional information below.
Did this regress from 2.7? Why? I haven't changed the tab clicking code, so 
this is pretty weird.

What steps will reproduce the problem?
1. Focus a window container (either by clicking, or using Tab).
2. Press the Context Menu key on the keyboard (it's near Right Ctrl).

What is the expected output? What do you see instead?
The context menu should show up correctly.

Instead, the menu opens, but is near the bottom of the screen, making it almost 
unusable.

What steps will reproduce the problem?
1. Install Tab Organizer.

What is the expected output? What do you see instead?
It should show a non-scary dialog box. Instead, it says that it needs all data 
on all websites!

Please provide any additional information below.
This is solely because of the keyboard shortcut that is used to open Tab 
Organizer. Unfortunately, this is the only way I know of to do this, because 
Chrome lacks proper APIs.

What steps will reproduce the problem?
1. Open the Tab Organizer popup.
2. Use it for a while, selecting different windows within Chrome.

What is the expected output? What do you see instead?
It should correctly show which window is selected, within Tab Organizer.

However, sometimes it stops updating, and the only way to fix it is to refresh 
the popup.

Please provide any additional information below.
It appears to be a sync issue with Options.addEventListener and 
Options.triggerEvent...

What steps will reproduce the problem?
1. Choose a non-blue theme.
2. Open Tab Organizer.

What is the expected output? What do you see instead?
Everything should look good. Instead, some parts are blue, regardless of what 
color the theme is.

Please provide any additional information below.
The parts we still need to colorize are:
* URL bar.
* Hovering the "New Window" button.
* Menu icon.

These we may or may not colorize:
* Hover over menu items.
* Background and category selector in the options page (?)
* Hover over tabs (?)
* Undo bar (?)

What steps will reproduce the problem?
1. Use Shift to select a tab in one window.
2. Use Shift to select a tab in a different window.

What is the expected output? What do you see instead?
Tabs should be selected in a horizontal line between the two tabs. Instead, 
only the 2 tabs are selected.

Please provide any additional information below.
Eesh, this will probably be tricky to solve, and then there's the question of 
whether we want to solve it at all or not...

Please describe the feature you want.
A couple users asked for session management within Tab Organizer. I'm not 
against the idea, per se, but I think it will be really hard to make it work 
correctly.

The problem, fundamentally, is with modes. Right now, Tab Organizer shows a 
list of all your current tabs. A session manager, on the other hand, shows a 
list of all your *past* tabs.

Because of this, we will probably need a way to switch from "normal" to 
"session manager" mode and back again. Aside from the obvious problems with 
modes, there's the tricky question of: how?

I don't think we can have it as a simple checkbox in the options. It needs to 
be something the user can change on-the-fly. Should we have a dropdown box that 
lets the user switch modes? That would take up precious space and also add UI 
clutter.

I've given this a lot of thought, and I just don't see a good way to implement 
it within Tab Organizer, without causing problems. There are already session 
manager extensions for Chrome, and you can run them at the same time as you use 
Tab Organizer.

However, I definitely welcome any ideas for how to implement this! If you have 
a good idea for how to add session management to Tab Organizer, please tell me.

What steps will reproduce the problem?
1. Open up Tab Organizer.
2. Refresh the popup many times.

What is the expected output? What do you see instead?
Memory should stay mostly the same. Instead, it increases by a large amount, 
every time you refresh the popup!

What version of the product are you using? On what operating system?
Version 2.6 with Chrome 7.0.503.1 on Debian GNU/Linux Lenny 5.0.6

Please provide any additional information below.
Does anybody else have this problem? Is this on GNU/Linux only?

Please describe the feature you want.
Right now, pinned tabs look the same as normal tabs. They also behave 
similarly, within Tab Organizer. This is bad because they behave differently in 
Chrome!

In addition to indicating which tabs are pinned or not, it would also be nice 
if a user could pin/unpin tabs within Tab Organizer. We should be careful to 
not bloat up the UI, though.

We should allow users to press "Ctrl+Z" to undo an action, rather than 
requiring them to click on the "Undo" link.

What steps will reproduce the problem?
1. Enable Tab Organizer
2. Open a Google text document

What is the expected output? What do you see instead?
The document should open normally. Instead, it hangs when loading the docs menu 
bar and then crashes.

What version of the product are you using? On what operating system?
Google Chrome version 7.0.517.0 dev
OS is Windows 7 Home Premium 64-bit

Please provide any additional information below.
It's happening with the new Google docs editor, don't know about the old one.

It'd be nice if users could choose what colors they want to use, in case they 
don't like blue, or they use a theme that isn't blue.

Shouldn't be too hard to implement as a dropdown box in the options page.

It would be nice if we could port Tab Organizer to Safari/Firefox/Opera.

Safari recently got their own extension system, and Firefox has been working on 
Jetpack. I have no clue what Opera has.

Most of the code is written in a browser-neutral manner, so a lot of this is 
just ripping out the Chrome-only parts and placing them in a separate file.

However, there may be a few odd bugs that could show up in the porting process, 
so this could be more complicated than I predict.

What steps will reproduce the problem?
1. Close a tab (for instance, with Middle Click).
2. Wait for it to scroll to the newly-focused tab.

What is the expected output? What do you see instead?
When the newly-focused tab is the last tab in the window, scrolling should be 
flush with the bottom of the container. Instead, it's flush with the bottom of 
the tab. This couple-pixel difference looks really bad.

It would probably be similar when the newly-focused tab is the first tab in the 
window. Both situations should be fixed.

We need a page that guides users on how to use Tab Organizer. It is a powerful 
program with some awesome features, but unfortunately a lot of users will never 
realize that.

A Help/FAQ page could help a lot, both helping users with their common 
problems, and also teaching them how to use the advanced features within Tab 
Organizer.

What steps will reproduce the problem?
1. Enter a search term.
2. Re-enter the same term later.

What is the expected output? What do you see instead?
It should remember the previous term and allow me to easily select it in a 
drop-down list. Instead, there is nothing.

Please provide any additional information below.
This is actually a tad tricky, because we perform searches incrementally, i.e. 
as you are typing. For instance, let's say you type out "foobar". We don't want 
to save "fo" or "foob" or even "fooba". We want to save only "foobar".

There are a few ways to solve this... we could make it so it only saves the 
search when you hit "enter". I suspect most users naturally hit "enter" when 
they're done typing, out of habit, so this might work out okay.

Another way would be to put a reasonably long timer (like 5 seconds) and only 
save the search after the timer has expired. This would, unfortunately, 
penalize people who are very slow typers, but of course there should be a 
setting in the options page to configure this.

What steps will reproduce the problem?
1. Change to use bubble mode in the options page.
2. Go to a page like http://google.com
3. Press the hotkey to open Tab Organizer.

What is the expected output? What do you see instead?
It should open. Instead, nothing happens.

What version of the product are you using? On what operating system?
Version 2.8 on Debian GNU/Linux Lenny 5.0.6

Please provide any additional information below.
What we used to do is open Tab Organizer in a popup, when using the hotkey, 
even when in bubble mode. Now we do nothing, which is obviously worse!

It is possible to use Shift+Ctrl+T to undo tabs, but that only undoes them one 
at a time, and there is a limit to how many you can undo.

It would be great if we could show a little "undo" button to allow the user to 
safely close tabs without worrying about permanent data loss.

It would be nice if we could know which options users prefer the most. For 
instance, I chose Ctrl+Shift+O to open Tab Organizer, but what if the majority 
of users prefer Alt+A? If so, then making Alt+A the default would make sense.

Ideally, it would also be possible to opt-out of this, or perhaps make it 
opt-in. I haven't decided yet.

We allow users to disable the undo bar in certain situations, but there are 
other things we could allow the user to change.

For instance, right now the undo bar automatically fades out after 10 seconds. 
Perhaps we should allow the user to change this behavior, for instance 
increasing/decreasing the time, or even changing the behavior altogether.

Please describe the feature you want.
When focusing a window container inside Tab Organizer, it'd be nice if it could 
also focus the relevant Chrome window.

This is especially helpful if you're trying to select a particular tab in a 
particular window. Although selecting the tab works, you have to use Alt+Tab 
(or the task bar) to search for which window the tab is in.

What steps will reproduce the problem? NOT SURE WHAT caused it.
1.
2.
3.

What is the expected output? What do you see instead?
Initially it worked for about a day or two. Now, clicking on it does not show 
anything. Clicked on the option dialog no longer show anything on the page.

What version of the product are you using? On what operating system?
Initially, I had 2.4 installed. Then upgraded to 2.5 and it stopped 
functioning. Windows 7 Ultimate/64 bit, Chrome 6.0.472.53.

Please provide any additional information below.
It had worked wonderfully. I really liked it and just start using it. Suddenly 
it stopped working. I have tried to uninstall it, restart PC, restart Chrome 
but it no longer worked.

Please let me know what can I do to help debugging this issue.

Thanks.

Please describe the feature you want.
When a tab is in a crashed state, we should indicate this to the user visually 
(for instance, by making the tab's background color grey).

In addition, we should provide an "is:crashed" search query.

What steps will reproduce the problem?
1. Turn on "Bubble mode" in the options.
2. Make sure the popup's width is greater than 800px.
3. Open Tab Organizer.

What is the expected output? What do you see instead?
When there is only 1-4 windows visible, there should not be a horizontal 
scrollbar. Instead, there is *always* a scrollbar, even when it is not needed.

Please provide any additional information below.
The technical reason for this, is that the bubble has a max width of 800px. 
Because the popup's contents are not in the flow, I need to use a bit of a hack 
to make bubble mode work. Unfortunately, this hack causes horizontal scrollbars.

I can't use `overflow: hidden` because we still need to show the scrollbar when 
the user has 5+ windows visible. The simple fix for users is to set the popup's 
width to 800px.

It appears that setting `max-width: 100%` on the <body> element fixes this.

What steps will reproduce the problem?
1. Open the popup.
2. Refresh the popup (quickly) many many many times.

What is the expected output? What do you see instead?
The events stored within Options should be 1 after each refresh.

Instead, the number of events grows over time.

Please provide any additional information below.
Seemingly randomly, an event will become stuck within Options, and will not be 
cleaned up. Although this seems to happen rarely, it should not be happening at 
all. These events can pile up over time, slowing down execution, so we should 
fix this.

What steps will reproduce the problem?
1. Have a window that is long enough to produce a vertical scrollbar.
2. Start dragging another tab into this window, but don't release it.
3. While still dragging the tab, move it near the top or bottom of the window 
(with scrollbars).

What is the expected output? What do you see instead?
The window should scroll up/down. Instead, it just sits there, and the only way 
to scroll is to first cancel the drag, scroll manually, then start the drag 
again.

Please provide any additional information below.
This is a problem in Chrome. Looks like we'll need to wait for WebKit to fix 
this, and then have the fix merged into Chrome.

What steps will reproduce the problem?
1. Open up the popup.
2. Open up the options page.
3. Select the "Theme" section in the options page.
4. Change the window theme, and note that both update properly.
5. Refresh the popup.
6. Change the window theme.

What is the expected output? What do you see instead?
The options page and popup should remain in sync. Instead, the popup updates 
correctly, but the options page stops updating.

If you refresh/reload the options page, it will now correctly update, but then 
the popup stops updating!

Please provide any additional information below.
This only happens when the 1st page is reloaded.

For instance:

If you open the popup first, then reload the options page, they stay in sync.
If you open the popup first, then reload the popup, things are broken.

If you open the options page first, then reload the popup, they stay in sync.
If you open the options page first, then reload the options page, things are 
broken.

What steps will reproduce the problem?
1. Focus a window container.
2. Press Alt+Tab (or similar) to unfocus the popup.

What is the expected output? What do you see instead?
The window container should remain focused, instead it's unfocused.

Please provide any additional information below.
This was fixed in version 2.5. Oddly enough, although it works sometimes, other 
times it (seemingly randomly) doesn't.

What steps will reproduce the problem?
1. Do something that triggers the undo bar.
2. Move the mouse so it hovers on top of the undo bar.
3. Wait for 10 seconds.

What is the expected output? What do you see instead?
The undo bar should remain open. Instead, it disappears.

Please provide any additional information below.
I think we should not remove the undo bar if the mouse is either over the undo 
bar itself, or over the <body> tag.

Please describe the feature you want.
Right now, we allow the user to press a key combination to open Tab Organizer. 
Should we also provide a way to close it?

I'm actually against this, for the simple reason that all the popular operating 
systems have ways to do this already. For instance, Alt+F4 on Windows, ⌘+W on 
OS X, etc.

Because of that, is this really a useful feature? I don't really see the 
benefit to having a separate "close" hotkey for Tab Organizer. Could somebody 
please enlighten me on why this is a good idea?

What steps will reproduce the problem?
1. Make sure there is only 1 window container visible.
2. Focus that container.
3. Press Tab repeatedly.

OR

1. Have only 1 window container.
2. Focus the container.
3. Create a new window with the "New Window" button.
4. Try to unfocus the window container.

What is the expected output? What do you see instead?
The container should lose focus, instead it appears to maintain it, even when 
something else has focus (i.e. the search box, "New Window" button, etc.)

Please provide any additional information below.
Probably caused by our fix for issue 27.

What steps will reproduce the problem?
1. Move multiple tabs at once.

What is the expected output? What do you see instead?
The order should be the same as it was originally. Instead, it's reversed.

For instance, if you have the following tabs:
1, 2, 3, 4, 5, 6, 7

They will now be:
7, 6, 5, 4, 3, 2, 1

The search box works very well, for the most common use cases. One area that it 
is lacking is with quotation marks.

Unfortunately, this will probably require a large overhaul of the search 
system, and may cause performance problems. We won't know until we try.


Here are some examples of use cases we should support:

"foo bar"
- Searches for tabs that have a URL or title that is "foo bar". Under normal 
circumstances, you cannot include spaces, because they are used for AND boolean 
logic.

"fOobAR"
- Quotation marks should be case-sensitive. Right now, we ignore case with 
searches. The above would not match "foobar" or "FooBar".

window:"foo"
- Searches for a window whose title is exactly "foo". Right now, we use a 
subset search, meaning that we could match "foo" or "foobar" or 
"foobarquxcorge". The above should match ONLY "foo", and nothing else.

"foo OR bar"
- Any sort of special syntax should be ignored within quotes.

"window:"
- Any search queries should also be ignored within quotes.

What steps will reproduce the problem?
1. Rename a window.
2. Click on the "Undo" link.

What is the expected output? What do you see instead?
The window should be renamed, and the text-box should be selected again.

Instead, it will unfocus everything, then about half a second later, select the 
text-box.

Please provide any additional information below.
The code works, but this "jumping" effect looks bad. Something weird with the 
window focus code, maybe?

What steps will reproduce the problem?
1. Visit a webpage, like http://www.google.com
2. Open the JavaScript console (Ctrl+Shift+J).

What is the expected output? What do you see instead?
Nothing. Instead, there is this error:

Uncaught Error: chrome.windows is not supported in content scripts. See the 
content scripts documentation for more details.

Please provide any additional information below.
This happens because of this line in lib/Platform.js:

ID_NONE: chrome.windows.WINDOW_ID_NONE,

What steps will reproduce the problem?
1. Switch to bubble mode in the options page.
2. Open the bubble.
3. Change the titles, the search query, etc.
4. Close the bubble.
5. Reopen the bubble.

What is the expected output? What do you see instead?
The titles and last-used search query should still be there. Instead, they're 
gone!

What version of the product are you using? On what operating system?
Version 2.8 on Debian GNU/Linux Lenny 5.0.6

Please provide any additional information below.
This used to work. I think I know why this is broken, so it should be an easy 
fix. Luckily, it only breaks in bubble mode!

It appears that the "beforunload" event is not fired for bubble mode. So I just 
need to change it to use "unload" instead.

Our drag-n-drop support is actually pretty good right now. However, other 
extensions use JavaScript drag-n-drop, such as jQuery UI. This not only works 
very well, but also looks good to boot.

There are some benefits to using native drag-n-drop, and in addition this will 
require drastically huge code changes. I tried a couple times to implement 
JavaScript drag-n-drop, but it was incredibly difficult.

Unfortunately, I can't just use jQuery UI or similar, because I have very 
specific requirements. jQuery UI, for instance, does not support both 
selectable and sortable at the same time.

On top of that, Tab Organizer is a 2D list, and the lists can overlap each 
other, which caused jQuery UI to break.

Because of that, I'm essentially forced to write my own drag-n-drop 
implementation from scratch, which is not an easy thing to do. This is 
something I'm still considering, but I don't plan to do this anytime soon.

Please describe the feature you want.
Using the "New Window" button within Tab Organizer creates a new window. 
Unfortunately, this new window appears on top of Tab Organizer, obscuring it.

It would be great if the new window could show up below Tab Organizer, that way 
users don't need to deal with the hassle of switching windows.

Please describe the feature you want.
It'd be great if there was some way to undo things. For instance, you close 10 
tabs at once, but then realize you want to get them back.

Or another situation is where you use "Move all selected" and realize that you 
want to move the tabs back to their old windows.

This could be implemented similar to GMail, with a box at the top, asking if 
the user wants to undo the action. This is nice because it fills in some empty 
space, and is unintrusive.

The downside is, it would only allow one level of undo. That's still 
drastically better than no undo at all, though.

It'd be neat if we could change the way the close button behaves in the options 
page.

For instance, right now we show the close button when hovering over the tab.

Some users may prefer to *always* show the close button, on every tab. Or 
always show the close button, but only on the selected tab.

riow:
wish the Red Cross tab deletion button move to the left side of the tab name, 
because length of tab names are varied but mostly short or middle, and clicking 
the red cross is more convenient in left side rather in right side

This could be especially useful when porting Tab Organizer to other browsers.

What steps will reproduce the problem?
1. Change the hotkey to Alt+A.
2. Press Alt and A simultaneously.

What is the expected output? What do you see instead?
Tab Organizer should open. Instead, nothing happens.

Please provide any additional information below.
It works properly if you first hold down Alt for a second, then press A.

What steps will reproduce the problem?
1. Close a tab (for instance, with Middle Click).

What is the expected output? What do you see instead?
It should scroll to the newly-focused tab.

Instead, it scrolls to the top of the window container, then quickly scrolls to 
the newly-focused tab. This makes it appear as if it "jumps". It only happens 
sometimes.

Please provide any additional information below.
It appears to be caused by the asynchronous time between closing a tab, and a 
new tab gaining focus.

What steps will reproduce the problem?
1. Change Tab Organizer to open in bubble mode.
2. Select or close a tab within Tab Organizer.

What is the expected output? What do you see instead?
The bubble should stay open. Instead, it closes automatically.

Please provide any additional information below.
This used to work (at least on GNU/Linux) a long time ago, but something the 
Chrome team did broke it.