darwinawardwinner / crm-custom Goto Github PK

See DarwinAwardWinner/ido-completing-read-plus#127 (comment)

To reproduce: Launch Emacs with -Q, then observe the following behavior.

(package-initialize)
(require 'magit)
(require 'crm-custom)
(crm-custom-mode)

(magit-completing-read-multiple* "" nil) ;; type "abc,def"
;; ("abc" "def")
(magit-completing-read-multiple* "" nil nil nil nil nil nil nil t) ;; type "abc,def"
;; "abc,def"

(require 's)

(magit-completing-read-multiple* "" nil) ;; type "abc" RET "def" RET RET
;; ("abc" "def")
(magit-completing-read-multiple* "" nil nil nil nil nil nil nil t ) ;; type "abc" RET "def" RET RET
;; nil

I expect the last form to return "abc,def" as well, but instead, nil is returned for any input when NO-SPLIT (the final parameter) is true.

I noticed the misbehavior in magit-log-other, and traced it to magit-completing-read-multiple* and (I think) the s-split invocation in crm-custom's advice.

I made a few notes as I went along in magit/magit#2668.

If the current input is something like a,b,c, and the user presses backspace, it should delete the trailing comma and return to completing c.