The gnocco from darvaza-proxy

gnocco's People

Contributors

gnocco's Issues

genroot's hardcoded output

currently genroot has the output location hardcoded in main.go. I do believe it should use stdout and/or -o ./roots

I have this on the dev-amery-darvaza branch currently to change the location. but it's definitively not the way

--- a/cmd/genroot/main.go
+++ b/cmd/genroot/main.go
@@ -23,7 +23,7 @@ var myroots = map[string]*ips{}

 const (
        url       = "https://www.internic.net/domain/named.root"
-       rootsfile = "doc/roots"
+       rootsfile = "cmd/gnocco/roots"
 )

 func trimDot(s string) string {

Make revive happy

At the moment revive is not that happy about Gnocco:

⚠  https://revive.run/r#package-comments  should have a package comment
server/gnocco/cache.go:1:1
⚠  https://revive.run/r#exported  exported function NewFromFilename should have comment or be unexported
server/gnocco/config.go:51:1
⚠  https://revive.run/r#exported  exported type GnoccoServer should have comment or be unexported
server/gnocco/server.go:14:6
⚠  https://revive.run/r#exported  type name will be used as gnocco.GnoccoServer by other packages, and that stutters; consider calling this Server
server/gnocco/server.go:14:6
⚠  https://revive.run/r#exported  exported method GnoccoServer.Addr should have comment or be unexported
server/gnocco/server.go:23:1
⚠  https://revive.run/r#exported  exported method GnoccoServer.Logger should have comment or be unexported
server/gnocco/server.go:27:1
⚠  https://revive.run/r#exported  exported method GnoccoServer.DumpCache should have comment or be unexported
server/gnocco/server.go:31:1
⚠  https://revive.run/r#exported  exported method GnoccoServer.Run should have comment or be unexported
server/gnocco/server.go:59:1
⚠  https://revive.run/r#exported  exported method GnoccoServer.ShutDown should have comment or be unexported
server/gnocco/server.go:106:1
⚠ 9 problems (0 errors, 9 warnings)

Warnings:
8  exported
1  package-comments

Please create a PR for that

Recommend Projects