dart-code / dart-code Goto Github PK

Similar to this one: https://github.com/Microsoft/vscode/blob/master/extensions/typescript/language-configuration.json (and referenced by the package.json file).

package installs successfully, after restart i get error message that sdk is not on path and must be configured in settings.
i have dart sdk in PATH and configuration of sdk in settings is not possible.

See TODO.

I don't see a lot of hyphens in the names of VSCode extensions. Dart would be ideal, but I guess already taken. Perhaps coordinate w/ the other plugin author? Or change the name to DartCode, Dart Code, Dart Tooling, ... ?

https://github.com/DanTup/Dart-Code/blob/master/syntaxes/yaml.plist

It seems better to just rely on it being available from vscode...

It would be nice to have the ability to run pub commands in the editor.

The Atom plugin has the following:

• pub run
• pub get
• pub upgrade
• pub global run
• pub global activate

From here:

do a timestamp check for pubspec.yaml vs .packages. If the pubspec file is newer, you know things are out-of-date.

It'd be good to have some idea of how often features are used. Investigate sending some basic events to Analytics counting activations and use of major features.

Looks like this would be sent if a file was deleted. Need to check if Code already removes listed errors for deleted files (if not, we should subscribe this and then set an empty set of errors for that file path).

See discussion in #38.

The Analysis Service API supports this, but VSCode API doesn't directly. Related issue for VSCode here.

There are some related comments in #36.

It would make it possible for other people to iterate on the generated analysis server wrapper (perhaps committed into a tool/ directory).

https://code.visualstudio.com/docs/extensionAPI/vscode-api#SignatureHelpProvider

VSCode doc
Analysis Server doc - getRefactorings
Analysis Server doc - getRefactoring

Some things in Google's API are 1-based but MS want 0-based. Shouldn't have to remember when to do this and when not. See TODO and TODO

I think this is a result of merging two API call results?

VSCode doc
Analysis Server doc

See TODO.

Makes sense to look at the testing capabilities. I've added to appveyor (currently only runs tsc) but if we can run them there even better.

Currently we need to provide all properties when creating instances of types. TypeScript doesn't seem to allow class-level fields to be optional so need to see what the options are (properties instead of fields? constructors?). Example here.

Code doesn't support per-language settings yet, so it's likely users want this but can't achieve it. Add an opt-out setting.

Most of this is already done but it didn't seem to work correctly (see microsoft/vscode#10048), but since I've added a wrapper (util.getConfig<T>) it should be simply to put back (setting removal is here)

For cases where analysis gets off-track.

Currently we don't seem to get line/col information for SDK files which makes it hard to make this work. I've posted in the analyzer-discuss forum to see if I'm missing something.

Downloaded .vsix to install on a VS2010 Ultimate test box. The error message does not present any version info.

See AnalysisOptions.

I don't think the method I'm using is the correct one; since it doesn't show all the things inside a class (I guess the clue was in the name, "top level").

(Splitting this out of #45 because that's merged and getting long...)

@devoncarew

I noticed that with the current document outlines, the highlights aren't the same as TypeScript (which highlights a whole class/method/whatever):

If I change the code to use the offset/length from the outline instead of the element it's much closer, but seems to include whitespace before it (so the closing } of a method is highlighted for the next method; I think this is by design based on earlier discussions with BW on the analyzer list).

I think I could make it work the same by using the start position from element but the end from outline (Code seems to always highlight full lines), however it feels a little bit wonky.

What do you think?

See TODO.

VSCode doc
Analysis Server doc

This looks exiting! I tried to install on a Mac, but I get the error that it cannot locate the Dart SDK (Dart-Code: Could not find a Dart SDK to use. Please add it to your PATH or set it in the extensions settings and reload).

I tried to configure it like this, but I still get the error:

$ cat "$HOME/Library/Application Support/Code/User/settings.json"
// Place your settings in this file to overwrite the default settings
{
    "dart.sdkPath": "/usr/local/Cellar/dart/1.18.1/"
}
$

There's an onDidChangeConfiguration event.

Currently it flashes up in the status bar (left) at startup; but TypeScript seems to always show it in the bottom right corner, so we should change to that.

See TODO.

We'll need to have something to keep track of open files (which listens to open/close events). The currently visible file should always be sent as the top item.

Currently the tooltips stack the doc comment and type, one right after the other. I think it would be easier to read if there was an extra new line between them.

Also It would be nice if the doc comments were formatted via markdown.

Requires some work in Code: microsoft/vscode#10401

See TODO

Stuff breaks if we open up files considered "dart like" that aren't being analysed.

We should avoid considering anything outside of the analysis roots as dart-like (or maybe "analyzable" would be a better name).

To support jump to definition.