Deployed app contains `*.map` files about angular_components_example HOT 17 CLOSED

@natebosch That was it! And I didn't have to rebuild anything so no issue there. Thanks.

from angular_components_example.

Yeah, I can add --no-source-maps to the release options for dart2js.

from angular_components_example.

Is there a scenario where we want to debug things?

I guess we can always rebuild the exact thing locally – so maybe good to get rid of.

from angular_components_example.

I think that the deployed app should be as slim 'n trim as possible -- just like the example Hacker News PWA.

from angular_components_example.

I have a counter to that. Internally we actually release all the .map files, and host all the dart files when we release. We do this so that developers can debug the gallery if they want and see how things are working.

The primary goal is for this to help developers. It should have the best practices we know about, but I don't really want to put a lot of work to make it as slim n trim as possible as that is not the purpose of it. The purpose is to document/help/showcase the widgets to developers.

from angular_components_example.

from angular_components_example.

Sure, that works for me, the problem is that the *.dart files aren't being published. Shouldn't they (if you actually want to debug from sources)?

from angular_components_example.

@kevmoo What would be the easiest way to let the .dart files be included when I build the gh-pages branch with peanut?

from angular_components_example.

You need to tweak the build.yaml file – @natebosch understands the bits here, I think

from angular_components_example.

You're explicitly configuring outputs from dart2js to not get filtered. What are the outputs that you want to keep from dart2js that are not .js or .js.map? Do we need to make the configuration more expressive to let you keep some other file while dropping the sourcemap files?

If you want instead to also keep .dart files you can add

      dart_web_compilers|dart_source_cleanup:
        options:
          enabled: false

from angular_components_example.

Looks like you wanted to keep the dumpinfo - why do you want that in release builds? If you feel it's important you can file an issue on the build repo asking for configuration which allows you to retain dumpinfo while removing sourcemaps. We'd have to introduce a new configuration option.

from angular_components_example.

from angular_components_example.

Looks like you wanted to keep the dumpinfo - why do you want that in release builds? If you feel it's important you can file an issue on the build repo asking for configuration which allows you to retain dumpinfo while removing sourcemaps.

@natebosch We do want serve the source maps and original dart files too. For the gallery it is helpful even from the published release to make experimenting with the live examples easier. Probably not something that most projects would want to do though.

from angular_components_example.

We do want serve the source maps and original dart files too.

SG, looks like you want

      dart_web_compilers|dart_source_cleanup:
        options:
          enabled: false

from angular_components_example.

@natebosch I'm having some issues getting it working. I tried a slightly modified version of the options you posted:

build_web_compilers|dart2js_archive_extractor:
    release_options:
        filter_outputs: false
build_web_compilers|dart_source_cleanup:
    release_options:
        enabled: false

I'm not sure the build is invalidated when changing these options (that might need an issue filed) but after running pub run build_runner clean and then running my release build again I still don't have the .dart sources available.

from angular_components_example.

@nshahan do you have a PR open so I can try to repro?

from angular_components_example.

oh, I just realized that the dart_source_cleanup needs to be disabled globally.

global_options:
  build_web_compilers|dart_source_cleanup:
    options:
      enabled: false

from angular_components_example.