Investigating: Weird build error when trying to cleanup imports about angular_components_example HOT 9 CLOSED

What about checking canRead first and ignoring anything which isn't generated yet?

from angular_components_example.

Guessing this is not an issue w/ this repo. Just a placeholder until we figure out where the bug is...

from angular_components_example.

It could just be that the uber import is missing some parts of the library. It is hand written. If that is really going to be the only entry point it would need to be generated.

from angular_components_example.

Whatever the root cause I think we also have an issue with build_runner here - we aren't writing the asset graph for this build...

from angular_components_example.

The angular_gallery_section package has a builder that reads imports, loads the files as assets looking for documentation and examples. It is possible there are some assumptions being broken by the single entry point. This will probably significantly increase the time it takes to run the build if all files are now part of every search.

from angular_components_example.

Filed dart-lang/build#1207
Will have a fix out for that soon which should make it easier to diagnose the root cause here since we'll be able to inspect an asset graph.

from angular_components_example.

The root cause here is an ordering issue.

package:material_select_example/material_dropdown_select_demo.template.dart is created in phase 368

One of the failing actions here is attempting to produce package:material_select_example/material_dropdown_select_demo.api.dart which is in phase 364 so it's not allowed to read an output from phase 368 but it tries to read that file

@nshahan - Currently angular_gallery_section has runs_before: ["angular|angular"] - do you know why it would need to read the .template.dart file? Is our ordering configuration insufficient here?

from angular_components_example.

Yeah I see why, it is listed as an import:
https://github.com/dart-lang/angular_components_example/blob/master/example/material_select_example/lib/material_dropdown_select_demo.dart#L25

The builder reads files seen as imports (transitively) looking for the classes and documentation to display in the gallery. The search is depth first so it turns out that we were just getting lucky before and finding what was needed before reaching the import that doesn't exist yet.

By changing to a single import, the files that actually contain the classes and docs the builder is looking for will not be read until much later.

I think one possible solution is to just avoid searching in .template.dart files because they should never contain what the builder is looking for.

from angular_components_example.

Fixed in #77.

from angular_components_example.