Git Product home page Git Product logo

Comments (5)

wpferguson avatar wpferguson commented on August 11, 2024

What were you trying to achieve by moving it up in the pixelpipe?

There's a reason behind the pixelpipe ordering and you just discovered it.

from darktable.

da-phil avatar da-phil commented on August 11, 2024

What were you trying to achieve by moving it up in the pixelpipe?

There's a reason behind the pixelpipe ordering and you just discovered it.

See my post above:

Motivation for using and moving scalepixels module on top of the pixel pipeline is the following:
If the module is activated after finishing a picture with several masks and drawings in the retouch module, the image warping is not reflected in the masks if it stays above demosaicing. Hence I moved it on top of all modules, except the crop module.

More concretely: after finishing a picture, I might notice that the desired crop does not work out without cropping away important parts of the image. Using the scale pixels module I'm able to squeeze the picture to make it fit into the aspect ratio of my desired crop.

That being said: the only module which causes this crash is "rotate and perspective", all others which might be sensitive above image boundaries (e.g. retouch and lens correction) do not lead to a crash or other issues. That's why I think it's a bug and the pixel pipe should be able to handle this rearrangement, but I'm not an expert on the concepts and limitations of the pixel pipe, so I'm open to discuss my expectations ;)

from darktable.

wpferguson avatar wpferguson commented on August 11, 2024

From the user manual....

Some cameras (such as the Nikon D1X) have rectangular instead of the usual square sensor cells. Without correction this would lead to distorted images.

So IIUC you're using the scale pixel module to correct a mask problem?

from darktable.

da-phil avatar da-phil commented on August 11, 2024

Apologies for giving a more precise answer only after sending my original reply, I edited it.

So my motivation is to make the final edit fit into a certain aspect ratio and crop. Let's say, I'm editing a 3:2 image and apply some corrections which modify the image area and therefore also the aspect ratio, like horizontal and/or vertical lens shift in the "rotate and perspective" module, or the lens correction module. Afterwards I want to be able to apply a 3:2 crop again, without sacrificing image area for the crop. The "scale pixels" module can be use to either squeeze (>1) or stretch the image vertically to make everything fit into the crop I need. Did this explanation help?

from darktable.

wpferguson avatar wpferguson commented on August 11, 2024

Now I understand.

from darktable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.