danmarsden / moodle-block_attendance Goto Github PK

Adding block_attendance (and mod_attendance) breaks the site, you get an error on login (Moodle 3.11.5):

Debug info: SELECT id,parent FROM {course_categories} WHERE id = ?
[array (
0 => '0',
)]
Error code: invalidrecord
Stack trace:

line 1646 of /lib/dml/moodle_database.php: dml_missing_record_exception thrown
line 1622 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
line 6742 of /lib/accesslib.php: call to moodle_database->get_record()
line 107 of /blocks/attendance/block_attendance.php: call to context_coursecat::instance()
line 341 of /blocks/moodleblock.class.php: call to block_attendance->get_content()
line 235 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
line 1181 of /lib/blocklib.php: call to block_base->get_content_for_output()
line 1239 of /lib/blocklib.php: call to block_manager->create_block_contents()
line 374 of /lib/blocklib.php: call to block_manager->ensure_content_created()
line 3984 of /lib/outputrenderers.php: call to block_manager->region_has_content()
line 40 of /theme/boost/layout/columns2.php: call to core_renderer->blocks()
line 1400 of /lib/outputrenderers.php: call to include()
line 1330 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 100 of /index.php: call to core_renderer->header()

Originally reported in Moodle forum post: Can't find data record in database table course_categories.

Salida de depuración habilitada
Descargando mod_attendance ...
<- https://moodle.org/plugins/download.php/28433/mod_attendance_moodle311_2021082610.zip
-> /var/www/moodledata/temp/core_plugin/code_manager/distfiles/5c554750d2795101a62ef0832de7e6ff.zip ... OK
Validando mod_attendance ... Error
[OK] Nombre del módulo externo que se debe instalar [attendance]
[OK] Versión del módulo externo [2021082610]
[Error] Versión de Moodle requerida [2021051700]
Instalación abortada debido a error de validación

contents of the version.php of the moodle in branch MOODLE_311_STABLE are as follows:

$version = 2021051715.06; // 20210517 = branching date YYYYMMDD - do not modify!
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
$release = '3.11.15+ (Build: 20230721)';// Human-friendly version name
$branch = '311';

Hi Dan,

With the recent upgrade of mod_attendance, the function construct_full_user_stat_html_table has been modified (mod/attendance/renderhelpers.php). This is now the current function definition:
function construct_full_user_stat_html_table($attendance, $user) {

However, it is being called this way (blocks/attendance/block_attendance.php):
$this->content->text .= construct_full_user_stat_html_table($attinst, $COURSE, $USER, $cm);

Which displays incorrect data due to $COURSE being passed instead of $USER.

Hi Dan,

I took both, the newest versions from block_attendance and mod_attendance from gitHub. Always when I wanted to add the block to my course, following notice/error occured and crashed my course:

Notice: Undefined property: attendance::$perm in /var/www/html/moodle_dev/blocks/attendance/block_attendance.php on line 79

Fatal error: Call to a member function can_take() on a non-object in /var/www/html/moodle_dev/blocks/attendance/block_attendance.php on line 79

Kind regards,
Kathrin

I am very interested in using your module to track attendance of students within Moodle. However, in my university the option of restricting the IP-addresses to avoid external registrations is not possible, because the IPs of the students can not be fixed or assigned to specific locations.

Another possibility is to extract the BSSID of the access points of the student's phone/PC when connected to the universities WiFi. I would like to be able to give a list of admissible BSSID (Mac-adresses) of APs in the vicinity of the class room (instead of IPs) which are cross-checked by moodle on the student's devices when they register their attendance.

Is it possible that you extend the implementation of you module?

Hi @danmarsden ,

When do you think you might have a version compatible with Moodle 4.3?

Based on my own initial quick test, most of it looks pretty good. The only issue I have come across so far is that I see the following error message when I go to take attendance:

Here is the error message from the above screenshot:

user_preference_allow_ajax_update() is deprecated. Please use the "core_user/repository" module instead.
line 41 of \lib\ajax\ajaxlib.php: call to debugging()
line 506 of \mod\attendance\classes\output\renderer.php: call to user_preference_allow_ajax_update()
line 497 of \lib\outputrenderers.php: call to mod_attendance\output\renderer->render_take_data()
line 104 of \mod\attendance\take.php: call to plugin_renderer_base->render()

Note: I am using Moodle 4.3 running on PHP 8.2.

Best regards,

Michael Milette

Cordial greeting

I have recently installed this plugin in my version 3.2 moodle. During the execution of the cron it returns an error that is very disturbing.
Could you tell me how to solve this fault or why it occurs?

During the execution of the cron the following message returns:
"Execute scheduled task: Consultar sesiones de asistencia que requieran registro automático (mod_attendance\task\auto_mark)
... started 16:18:52. Current memory use 15.4MB.
No unmarked status configured for session id: 797
...
0 session status updated
!!! Detectado un error de codificación, debe ser corregido por un programador: A lock was created but not released at:
[dirroot]/lib/classes/task/manager.php on line 483

Code should look like:

$factory = \core\lock\lock_config::get_lock_factory('type');
$lock = $factory->get_lock(Resource id #583);
$lock->release(); // Locks must ALWAYS be released like this.

!!!
"
I am attentive to your indications, thank you very much for your attention

I have the attendance block and module configured on my Moodle site. The block will not display any information in the student view. Although 2 attendance sessions have been recorded, the block in the students view shows the "Taken sessions" as 0 and the "Points over taken sessions" as 0/0. The "Percentage over all sessions" is listed as "0" as well.

Version 2013070302

Invalid get_string() identifier: 'attendance:addinstance' or component 'block_attendance'. Perhaps you are missing $string['attendance:addinstance'] = ''; in /var/www/beta/blocks/attendance/lang/en/block_attendance.php? line 293 of /lib/classes/string_manager_standard.php: call to debugging() line 6856 of /lib/moodlelib.php: call to core_string_manager_standard->get_string() line 2962 of /lib/accesslib.php: call to get_string() line 2820 of /lib/accesslib.php: call to get_capability_string() line 113 of /admin/roles/classes/capability_table_base.php: call to get_capability_docs_link() line 139 of /admin/roles/classes/capability_table_with_risks.php: call to core_role_capability_table_base->display() line 624 of /admin/roles/classes/define_role_table_advanced.php: call to core_role_capability_table_with_risks->display() line 267 of /admin/roles/define.php: call to core_role_define_role_table_advanced->display()

Our users preferred one aspect of the older block output that included the totals for PLEA directly in the block. Some of our instructors deduct points for absences, and they like to have the running totals directly visible from the main course page to keep students aware of this. They like the new output that provides the total count out of completed sessions as well as available sessions as well - is there any way to add the PLEA totals back to the block output, and/or provide a setting that allows the admin to customize what the block displays? Thank you!

Hi, I work for Remote Learner and just added the 'new' attendance module to our clients sites. Our techs are seeing the following messages when on the blocks.php page - looks just like some missing lang strings

Invalid get_string() identifier: 'donotusepaging' or component 'attendance'. Perhaps you are missing $string['donotusepaging'] = ''; in mod/attendance/lang/en/attendance.php?

line 6927 of /lib/moodlelib.php: call to debugging()
line 7619 of /lib/moodlelib.php: call to core_string_manager->get_string()
line 32 of /mod/attendance/settings.php: call to get_string()
line 3368 of /lib/pluginlib.php: call to include()
line 17 of /admin/settings/plugins.php: call to plugininfo_mod->load_settings()
line 6416 of /lib/adminlib.php: call to require()
line 177 of /admin/blocks.php: call to admin_get_root()

Invalid get_string() identifier: 'resultsperpage' or component 'attendance'. Perhaps you are missing $string['resultsperpage'] = ''; in mod/attendance/lang/en/attendance.php?

line 6927 of /lib/moodlelib.php: call to debugging()
line 7619 of /lib/moodlelib.php: call to core_string_manager->get_string()
line 43 of /mod/attendance/settings.php: call to get_string()
line 3368 of /lib/pluginlib.php: call to include()
line 17 of /admin/settings/plugins.php: call to plugininfo_mod->load_settings()
line 6416 of /lib/adminlib.php: call to require()
line 177 of /admin/blocks.php: call to admin_get_root()

Invalid get_string() identifier: 'resultsperpage_desc' or component 'attendance'. Perhaps you are missing $string['resultsperpage_desc'] = ''; in mod/attendance/lang/en/attendance.php?

line 6927 of /lib/moodlelib.php: call to debugging()
line 7619 of /lib/moodlelib.php: call to core_string_manager->get_string()
line 43 of /mod/attendance/settings.php: call to get_string()
line 3368 of /lib/pluginlib.php: call to include()
line 17 of /admin/settings/plugins.php: call to plugininfo_mod->load_settings()
line 6416 of /lib/adminlib.php: call to require()
line 177 of /admin/blocks.php: call to admin_get_root()
I saw this in Moodle 2.5.2

If I had more than one Attendance activity to the course, and after I delete an Attendance activity, it will always be shown on the bloc. If I try to clic on bloc links related to the deleted Attendance activity, an alert is displayed on the top of course content page : "Suppression d'activité en cours..." (in english : "deletion of activity in progress...") but noting changes.

Hey there!
We are using your plugin on our site as a git submodule - it is hard for us to track if a new version is out, and which commit does it correspond to. Would it be possible to add tags to corresponding commits, upon which the releases are based?

Thank you,
Miroslav Jarý
FEE CTU in Prague