danielschenk / zpf-backstage-tv Goto Github PK

In the template, unique classes are defined (like: class="act-{{ key }}") which are used by the JavaScript to select all inputs which belong to a certain act. This is obviously not an intended use case of classes.

These should all be replaced by HTML5 custom data attributes, like:

<input data-act="{{ key }}" ...

This is already partly done for the free field inputs.

Alternatively, look into passing this in event handlers which could in some cases be sufficient to find the object needed (eg. as parent or sibling of).

It would be nice to have automated tests which:

• run the Docker image
• do the most important requests on it

This makes it much less work to take in eg. Dependabot PRs, because successful PR runs prove that the important functionality still works.

For each of the 4 days, the schedule is fetched first, and subsequently, all act pages are fetched to get descriptions. If one of these fail (eg. due to a bad connection or HTML parsing error) the rest of the days' schedules are not fetched anymore in that cycle.

As show times are a critical part of the system, make sure that an error in getting details doesn't stop updating the show times alone.

See #61. Build fails due to gcc missing in python-slim-iot image (which is based on python-slim). Solution: do multi-stage build (like in Dockerfile of python-slim-iot): do pip install to a venv using a normal python image as base, then copy files to the target image based on the slim image.

The overview does not show the act times for acts with multiple shows, whilst the block schedule does.

Nice to have for #67, so that when an event is changed and doesn't match the festival web site anymore, reminders can be corrected

Possibly because of an old act key in the rooms data, for which no button exists anymore.

• #71
• #70

Mostly happens after initial load. It seems the button for the day before the actual day doesn't respond. After selecting a different day everything works again. Maybe something related to the active hash and onhashchange not triggering.

To accommodate for swapping the backend device out.

Options:

• Long poll
• Websockets
• ...?

Tracking issue for:

• https://github.com/danielschenk/zpf-backstage-tv/security/code-scanning/3

https://flask-login.readthedocs.io/en/latest/#login-example