daniel-rose / magento2-gallery Goto Github PK

Hi,
when i compile, i received this error :

Compilation was started.
Interception cache generation... 6/7 [========================>---] 85% 29 secs 298.0 MiBErrors during configuration scanning:
DavidVerholen\Teaser\Api\TeaserGroupRepositoryInterface\Proxy
Invalid proxy class for DavidVerholen\Teaser\Api\TeaserGroupRepositoryInterface
Total Errors Count: 1

[Magento\Framework\Validator\Exception]
Error during compilation

Hi Daniel Rose,
When user create a new gallery and select a image that was selected on another gallery.
The image filter function will not load.
I think SQL statement is wrong. My first solution: With other Gallery, i will only show images that never were selected.

In file DR/Gallery/Block/Adminhtml/Gallery/Edit/Tab/Image.php

protected function _prepareCollection()
    {
        /** @var Collection $collection */
        $collection = $this->collectionFactory->create();
        $collection->getSelect()->joinLeft(
            ['link_table' => $collection->getTable('dr_gallery_gallery_image')],
            'main_table.image_id = link_table.image_id',
            ['gallery_id', 'position']);

        $this->setCollection($collection);
        return parent::_prepareCollection();
    }

I edited this function to solved this issue.

protected function _prepareCollection()
    {
        /** @var Collection $collection */
        $collection = $this->collectionFactory->create();
        $collection->getSelect()->joinLeft(
            ['link_table' => $collection->getTable('dr_gallery_gallery_image')],
            'main_table.image_id = link_table.image_id',
            ['gallery_id', 'position'])
            ->where("link_table.image_id is null");

        $this->setCollection($collection);
        return parent::_prepareCollection();
    }

My second solution: Filter all images, and allow select duplicated images.

when we click on any gallery images it's images showing on footer without popup.

Hi Daniel,

I using your extension and have a bug.

Missing required argument $connectionName of DR\Gallery\Model\ResourceModel\Gallery

After i re-compile , my site work. But after a few day, the bug appear again.

I will post my solution after i solve this problem.

Thanks and Best Regards,

I've tried to add an new image to an existing gallery but :

• the image can't be found in the grid images in the gallery option
• only the actual images in the gallery are shown.
• even using the search, the "all" yes or no filter, searching by name or title nothing works...

Seems a bug, the only way to add an image to an existing gallery is to recreate it from the beginning. painfull

Would you be so kind to update your readme.md with features set and status of the extension, please?

Hello
I was testing your gallery in magento2 but i found that Filter is not working inside the Image Tab. It only showing Filtered "Yes" when you try another filter like "ANY" and again try to put "YES" into filter then it just stop everything on browser. BTW nice work on grid.

When I am compiler at Magento 2.2.1 , it not accept ..
Do you know what happened it is ? or can tell me how to fix that !
Thanks~

When creating new Gallery there is list of all images and you can select desired ones to be included in Gallery.

But when you edit existing gallery, you can only see already added images. If you want to add additional ones you have to Choose Any from dropdown selector and click Search. In my installation I get JavaScript error

Uncaught RangeError: Maximum call stack size exceeded

Same thing happens when creating new gallery and you try to use Search feature of the Images grid.