damr- / rummy Goto Github PK

Figure out when finding sets/runs/duos which use some of the same cards is needed and when the found card packs should be unique.

**Example **
Having J♦Q♦Q♦ detects two duos J♦Q♦, each with a different Q♦.
Keeping both Q♦ on hand is unnecessary though, as long as they cannot be used elsewhere.

Add functionality to detect runs of any length including joker cards, but the latter may only start/end a run if its length is 3.

Then the separate detection of joker-card finished duo-runs can be removed.

Currently, cards which are laid down alone ("singles") are put at the first possible card spot.
There are scenarios (concerning runs) where this is not optimal and more thought should be put into this.

Example
The run J♠Q♠K♠ is laid down and there are a black Joker and a 9♠ on hand. Currently, the joker will always be added at the end of the run and the 9♠ cannot be used.

Example 2
The run J♠Q♠K♠ and the set 10♦10♣10♥ are laid down. A 10♠ and a 9♠ are on hand. Currently, there is no mechanism to detect that adding 9♠10♠ to the run is better than just finishing the set with the 10♠.

Possible solutions

• Check whether attaching a single onto a run will allow another card to be put there too.
• Check for cards on hand whose rank is highestRank+2 or lowestRank-2 of a run and whether another card can fill that gap (be it a joker or the exact card with the right rank and suit).
  If no card can fill the gap, try to keep the single on hand anyway (unless there are <3 cards on hand)
• Check if duos can be appended onto a run and prioritize them over singles.

Furthermore, single cards should prioritize card spots where they can replace a joker.

Player cannot have more than 13 cards, but after few moves player is grabbing some cards from other players cards instead of deck. When player draws cards from other player, it is also simultaneously drawing a card from Deck, as a result one player gets more than 13 cards in his hands and other player gets less than 13 cards in his hand.
Please fix this issue
I am currently converting this ai project into manual project. I haven't changed anything yet but I found out this bug. Please if you have any manual project for rummy please send it to me. It will be big help for me to learn this things.

Thank you in advance!
Waiting for your response...