dal-mzhang / loc-flow Goto Github PK

Hi, thanks for sharing this amazing workflow. It is very convenient and friendly to beginners. However, I have a few questions about the runphasenet.py file.

1. Reference time
   

   LOC-FLOW/Pick/PhaseNet/runphasenet.py

   Lines 38 to 39 in b61de97

   	data[["year", "mon", "day"]] = data["begin_time"].apply(lambda x: pd.Series([f"{x.year:04d}", f"{x.month:02d}", f"{x.day:02d}"]))
   	data["ss"] = data["begin_time"].apply(lambda x: (x - datetime.fromisoformat(f"{x.year:04d}-{x.month:02d}-{x.day:02d}")).total_seconds())

   
   Here the begin_time is used to determined the target day. However, the pick can be on a different day (e.g. the next day of the begin_time). Why not use phase_time directly?

2. Amplitude
   Another confusion is the amplitude multiplied by 2800*20. What is the purpose of multiplication by 2800*20? Besides, is it necessary to first remove instrumental to get the true amplitude?
   

   LOC-FLOW/Pick/PhaseNet/runphasenet.py

   Line 42 in b61de97

   data["phase_amp"] = data["phase_amp"] * 2080 * 20

Thanks again for the package.